linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Josh Triplett <josh@freedesktop.org>
Cc: linux-sparse@vger.kernel.org
Subject: [PATCH 2/3] sparse test suite: add test mixing __context__ and __attribute__((context(...)))
Date: Thu, 10 Apr 2008 15:25:21 +0200	[thread overview]
Message-ID: <20080410132618.299342000@sipsolutions.net> (raw)
In-Reply-To: 20080410132519.049821000@sipsolutions.net

[-- Attachment #1: context-named-mixed-goto.patch --]
[-- Type: text/plain, Size: 828 bytes --]

An earlier version of the next patch had a bug that this test catches.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 validation/context-named.c |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

--- sparse.orig/validation/context-named.c	2008-04-10 14:57:26.000000000 +0200
+++ sparse/validation/context-named.c	2008-04-10 15:23:16.000000000 +0200
@@ -465,6 +465,27 @@ static void warn_exact_fn2(void)
     r2();
 }
 
+#define __acquire(x)	__context__(x,1)
+#define __release(x)	__context__(x,-1)
+
+#define rl() \
+  do { __acquire(RCU); } while (0)
+
+#define ru() \
+  do { __release(RCU); } while (0)
+
+static void good_mixed_with_if(void)
+{
+    rl();
+
+    if (condition) {
+        a();
+        r();
+    }
+
+    ru();
+}
+
 /*
  * check-name: Check -Wcontext with lock names
  *

-- 


  parent reply	other threads:[~2008-04-10 14:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 13:25 [PATCH 0/3] improve context handling Johannes Berg
2008-04-10 13:25 ` [PATCH 1/3] make sparse keep its promise about context tracking Johannes Berg
2008-04-10 15:24   ` Philipp Reisner
2008-04-10 15:30     ` Johannes Berg
2008-04-10 15:46       ` Philipp Reisner
2008-04-10 15:51         ` Johannes Berg
2008-04-10 16:05           ` Philipp Reisner
2008-04-10 16:12             ` Johannes Berg
2008-04-10 21:21               ` Philipp Reisner
2008-04-11 19:53                 ` Josh Triplett
2008-04-18 12:35                   ` Johannes Berg
2008-04-11 11:06             ` Johannes Berg
2008-04-21 19:34             ` Josh Triplett
2008-04-21 19:37               ` Johannes Berg
2008-04-10 15:54         ` Johannes Berg
2008-04-21 19:22       ` Josh Triplett
2008-04-21 18:04   ` Josh Triplett
2008-04-21 18:11     ` Johannes Berg
2008-04-21 18:26       ` Josh Triplett
2008-04-21 18:30         ` Johannes Berg
2008-04-21 18:51           ` Josh Triplett
2008-04-10 13:25 ` Johannes Berg [this message]
2008-04-10 13:25 ` [PATCH 3/3] sparse: simple conditional " Johannes Berg
2008-04-11 11:07 ` [PATCH 4/3] inlined call bugfix & test Johannes Berg
2008-04-11 11:08 ` [PATCH 5/3] improve -Wcontext code and messages Johannes Berg
2008-04-21 18:37 ` [PATCH 0/3] improve context handling Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080410132618.299342000@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=josh@freedesktop.org \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).