From: Sam Ravnborg <sam@ravnborg.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-sparse@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] sparse: Increase pre_buffer[] and check overflow
Date: Tue, 8 Jul 2008 22:45:47 +0200 [thread overview]
Message-ID: <20080708204547.GA16742@uranus.ravnborg.org> (raw)
In-Reply-To: <20080709.002805.128619748.anemo@mba.ocn.ne.jp>
On Wed, Jul 09, 2008 at 12:28:05AM +0900, Atsushi Nemoto wrote:
> I got this error when running sparse on mips kernel with gcc 4.3:
>
> builtin:272:1: warning: Newline in string or character constant
>
> The linus-mips kernel uses '$(CC) -dM -E' to generates arguments for
> sparse. With gcc 4.3, it generates lot of '-D' options and causes
> pre_buffer overflow.
Why does mips have this need when all other archs does not?
We should fix sparse so it is dynamically allocated - but
that is not an excuse for mips to use odd stuff like this.
So please someone from mips land explain why this is needed.
Sam
next prev parent reply other threads:[~2008-07-08 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 15:28 [PATCH] sparse: Increase pre_buffer[] and check overflow Atsushi Nemoto
2008-07-08 15:59 ` Atsushi Nemoto
2008-07-10 17:51 ` Al Viro
2008-07-10 18:09 ` Morten Welinder
2008-07-08 20:45 ` Sam Ravnborg [this message]
2008-07-09 16:18 ` Atsushi Nemoto
2008-07-09 16:32 ` Sam Ravnborg
2008-07-10 17:39 ` Al Viro
2008-07-11 16:07 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708204547.GA16742@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).