From: Christoph Hellwig <hch@lst.de>
To: linux-sparse@vger.kernel.org
Subject: lock context warnings
Date: Wed, 7 Jan 2009 09:45:40 +0100 [thread overview]
Message-ID: <20090107084539.GA15246@lst.de> (raw)
Since a few month sparse keeps spewing tons of wrong lock context
warnings like:
/home/hch/work/linux-2.6/fs/xfs/quota/xfs_dquot.c:1341:24: warning:
context problem in 'xfs_qm_dqflush_done': 'xfs_trans_ail_delete'
expected different context
/home/hch/work/linux-2.6/fs/xfs/quota/xfs_dquot.c:1341:24: context
'xa_lock': wanted >= 1, got 0
/home/hch/work/linux-2.6/fs/xfs/quota/xfs_dquot_item.c:565:22: warning:
context problem in 'xfs_qm_qoffend_logitem_committed':
'xfs_trans_ail_delete' expected different context
/home/hch/work/linux-2.6/fs/xfs/quota/xfs_dquot_item.c:565:22:
context 'xa_lock': wanted >= 1, got 0
which mean lock context annotations just don't seem to work, e.g. the
fist one is:
/* xfs_trans_ail_delete() drops the AIL lock. */
spin_lock(&ailp->xa_lock);
if (qip->qli_item.li_lsn == qip->qli_flush_lsn)
xfs_trans_ail_delete(ailp, (xfs_log_item_t*)qip);
else
spin_unlock(&ailp->xa_lock);
where xfs_trans_ail_delete prototyped as:
void xfs_trans_ail_delete(struct xfs_ail *ailp,
struct xfs_log_item *lip)
__releases(ailp->xa_lock);
These messages are highly annoying in a kernel build, so if you can't
fix them easily, please at least remove the lock context stuff from
the default check flags.
next reply other threads:[~2009-01-07 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 8:45 Christoph Hellwig [this message]
2009-01-07 9:20 ` lock context warnings Alexey Zaytsev
2009-01-07 16:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107084539.GA15246@lst.de \
--to=hch@lst.de \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).