From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: fun with declarations and definitions
Date: Tue, 3 Feb 2009 04:41:56 +0000 [thread overview]
Message-ID: <20090203044156.GI28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <70318cbf0902021907w634ffc6dm693022b23a0eabfc@mail.gmail.com>
On Mon, Feb 02, 2009 at 07:07:24PM -0800, Christopher Li wrote:
> > } else if (base_type && base_type->type == SYM_FN) {
> > + if (decl->next_id && decl->next_id->scope == decl->scope)
>
> Not sure what this is trying to do. Shouldn't the next line to be indented
> if I read it correctly?
Yuck. That's a leftover that hadn't been caught since it affects only
K&R definitions. Kill that line...
ObDeclarationParsing: I'm sorely (_very_ sorely) tempted to claim that
gcc folks are violating GPL. Proof: gcc/c-parse.in, around productions
for declspecs_*. Of course, they can say that this _is_ the preferred
form for making modifications, but having such admission made in public
would be worth it... Trying to sort out the __attribute__ handling in
there just plain hurts ;-/
next prev parent reply other threads:[~2009-02-03 4:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 7:30 fun with declarations and definitions Al Viro
2009-02-02 20:17 ` Christopher Li
2009-02-02 20:58 ` Al Viro
2009-02-02 22:25 ` Christopher Li
2009-02-03 3:07 ` Christopher Li
2009-02-03 4:13 ` Al Viro
2009-02-05 18:40 ` Christopher Li
2009-02-05 18:47 ` Derek M Jones
2009-02-05 20:28 ` Al Viro
2009-02-05 21:19 ` Al Viro
2009-02-06 5:36 ` Al Viro
2009-02-09 7:52 ` Christopher Li
2009-02-09 8:54 ` Al Viro
2009-02-05 22:41 ` Christopher Li
2009-02-05 23:22 ` Al Viro
2009-02-03 4:41 ` Al Viro [this message]
2009-02-03 6:28 ` Ralf Wildenhues
2009-02-05 18:52 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203044156.GI28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).