From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christopher Li <sparse@chrisli.org>
Cc: Al Viro <viro@ftp.linux.org.uk>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH 1/7] Fix handling of ident-less declarations
Date: Sat, 14 Feb 2009 21:30:32 +0000 [thread overview]
Message-ID: <20090214213032.GQ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090214203154.GP28946@ZenIV.linux.org.uk>
On Sat, Feb 14, 2009 at 08:31:54PM +0000, Al Viro wrote:
> On Sat, Feb 14, 2009 at 07:08:36PM +0000, Al Viro wrote:
> > On Sat, Feb 14, 2009 at 10:45:41AM -0800, Christopher Li wrote:
> > > On Sat, Feb 14, 2009 at 4:25 AM, Al Viro <viro@ftp.linux.org.uk> wrote:
> > > >
> > > > The rule for ident-less declaration is
> > >
> > > wow, great.
> > >
> > > The series applies to the tree fine. First impression of the series
> > > looks fine. I am still working on it.
> > >
> > > Thanks for the patches. BTW, this is not the "lazy type evaluation"
> > > you are talking about right?
> >
> > No, just the first batch of declaration parser fixes... The next group is
> > about separating ctype-as-part-of-symbol from ctype-as-parser-state uses.
> > After that - getting declaration_specifiers() to sane shape, which, BTW,
> > will relieve the situation with mode bits. Then - cleaning up the type
> > handling...
>
> BTW, I wonder whether if it would be better to just scan for the end
> of attributes after ( when we are deciding whether it's a function or
> nested declarator, leaving the actual handling of these guys to after
> the decision. The thing is, unlike gcc we have the token list anyway,
> and it's easier to not bother with passing that crap to parameter_type_list(),
> etc.
>
> I'll try to do that and see what falls out; potentially that replaces
> 7/7 in this series.
... no, it doesn't ;-/ Too much PITA with error recovery, so the original
version still stands. Alas.
next prev parent reply other threads:[~2009-02-14 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 12:25 [PATCH 1/7] Fix handling of ident-less declarations Al Viro
2009-02-14 18:45 ` Christopher Li
2009-02-14 19:08 ` Al Viro
2009-02-14 20:31 ` Al Viro
2009-02-14 21:30 ` Al Viro [this message]
[not found] ` <70318cbf0902151633w77dc151ek7a6205430d2a19b8@mail.gmail.com>
[not found] ` <20090216014234.GS28946@ZenIV.linux.org.uk>
2009-02-16 11:14 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090214213032.GQ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).