From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Christopher Li <sparse@chrisli.org>,
linux-sparse@vger.kernel.org, Hannes Eder <hannes@hanneseder.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Nasal demons in preprocessor use (Re: [PATCH] test-suite: new preprocessor test case)
Date: Thu, 19 Mar 2009 19:07:31 +0000 [thread overview]
Message-ID: <20090319190730.GC28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <154e089b0903191151q37ab7b20o43838845af12966f@mail.gmail.com>
On Thu, Mar 19, 2009 at 07:51:22PM +0100, Hannes Eder wrote:
> When currently running sparse agains the current linux-next tree, a
> lot of checks produce error messages like this:
>
> include/linux/skbuff.h:381:9: error: expected preprocessor identifier
Cute. If anything, this kmemcheck_define_bitfield stuff needs to be moved
inside the ifdefs.
Folks, this is not a valid C, period. And no, there's no promise that
gcc won't change its behaviour on such constructs whenever they feel
like that.
Preprocessor directives do not belong in argument lists. Not #ifdef,
not #define, not #include; this is undefined behaviour.
next prev parent reply other threads:[~2009-03-19 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 17:56 [PATCH] test-suite: new preprocessor test case Hannes Eder
2009-03-19 18:26 ` Al Viro
2009-03-19 18:51 ` Hannes Eder
2009-03-19 19:07 ` Al Viro [this message]
2009-03-19 19:27 ` Nasal demons in preprocessor use (Re: [PATCH] test-suite: new preprocessor test case) Ingo Molnar
2009-03-19 19:39 ` Al Viro
2009-03-19 20:20 ` Vegard Nossum
2009-03-19 22:07 ` Stephen Rothwell
2009-03-20 18:08 ` Ingo Molnar
2009-03-20 19:04 ` Al Viro
2009-03-20 19:14 ` Al Viro
2009-03-20 23:16 ` Vegard Nossum
2009-03-20 23:44 ` Al Viro
2009-03-21 8:34 ` Johannes Berg
2009-03-27 3:13 ` H. Peter Anvin
2009-03-19 19:24 ` [PATCH] test-suite: new preprocessor test case Derek M Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319190730.GC28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hannes@hanneseder.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sparse@chrisli.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).