From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Christopher Li <sparse@chrisli.org>,
linux-sparse@vger.kernel.org, Hannes Eder <hannes@hanneseder.net>,
linux-kernel@vger.kernel.org
Subject: Re: Nasal demons in preprocessor use (Re: [PATCH] test-suite: new preprocessor test case)
Date: Fri, 20 Mar 2009 23:44:12 +0000 [thread overview]
Message-ID: <20090320234412.GK28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <19f34abd0903201616v4175b5afn5630fcae02d7ff4f@mail.gmail.com>
On Sat, Mar 21, 2009 at 12:16:17AM +0100, Vegard Nossum wrote:
> (The solution you sketched is still quite an uglification of the
> original code, something we tried to minimize using the construct you
> saw.)
Frankly, I'd suggest expanding that sucker and being done with that.
However, more interesting question is whether you really need the
named field to be a struct. If not, something like
bitfields_start(name)
....
bitfields_end
would work just fine, without all that fun.
next prev parent reply other threads:[~2009-03-20 23:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 17:56 [PATCH] test-suite: new preprocessor test case Hannes Eder
2009-03-19 18:26 ` Al Viro
2009-03-19 18:51 ` Hannes Eder
2009-03-19 19:07 ` Nasal demons in preprocessor use (Re: [PATCH] test-suite: new preprocessor test case) Al Viro
2009-03-19 19:27 ` Ingo Molnar
2009-03-19 19:39 ` Al Viro
2009-03-19 20:20 ` Vegard Nossum
2009-03-19 22:07 ` Stephen Rothwell
2009-03-20 18:08 ` Ingo Molnar
2009-03-20 19:04 ` Al Viro
2009-03-20 19:14 ` Al Viro
2009-03-20 23:16 ` Vegard Nossum
2009-03-20 23:44 ` Al Viro [this message]
2009-03-21 8:34 ` Johannes Berg
2009-03-27 3:13 ` H. Peter Anvin
2009-03-19 19:24 ` [PATCH] test-suite: new preprocessor test case Derek M Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320234412.GK28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hannes@hanneseder.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=sparse@chrisli.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).