Re: [PATCH] linearize.h: sanitize header

[Kamil Dudka <kdudka@redhat.com>]

On Thu August 6 2009 11:23:26 Hannes Eder wrote:
> On Thu, Aug 6, 2009 at 11:02, Kamil Dudka<kdudka@redhat.com> wrote:
> > It's unfortunate to use 'true' and 'false' as identifiers in a system
> > header. It clashes with corresponding macros from <stdbool.h> when
> > included before <sparse/linearize.h>.
> >
> > Signed-off-by: Kamil Dudka <kdudka@redhat.com>
> > ---
> >  linearize.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/linearize.h b/linearize.h
> > index 2205082..50b3601 100644
> > --- a/linearize.h
> > +++ b/linearize.h
> > @@ -328,7 +328,7 @@ struct entrypoint {
> >         struct instruction *entry;
> >  };
> >
> > -extern void insert_select(struct basic_block *bb, struct instruction
> > *br, struct instruction *phi, pseudo_t true, pseudo_t false); +extern
> > void insert_select(struct basic_block *bb, struct instruction *br, struct
> > instruction *phi, pseudo_t if_true, pseudo_t if_false);
>
> I guess it is wise to change this in linearize.c as well.  Mind sending a
> patch?

The question is if we need/want to :-) It's change of the working code for no 
real benefit. I am talking only about system-wide headers which can be 
included anywhere.

Kamil