Re: [PATCH] linearize.h: sanitize header

[Kamil Dudka <kdudka@redhat.com>]

On Thu August 6 2009 11:39:11 Hannes Eder wrote:
> >> I guess it is wise to change this in linearize.c as well.  Mind sending
> >> a patch?
> >
> > The question is if we need/want to :-) It's change of the working code
> > for no real benefit. I am talking only about system-wide headers which
> > can be included anywhere.
>
> Well I see at least one benefit, a small one though.  Syntax
> highlighting is somewhat confused with "true" and "false", at least
> emacs is.  They appear like the constants, where in fact they are
> variables.

I can confirm it's the same case with the vim's syntax highlighter.

> The likelyhood to break the code by renaming this two variables is
> kinda low, no?  And IHMO it was not so wise in the first place to pick
> these names. ;)

I would contend that only two variables are affected. They are if we consider 
only headers. However the situation is much worse when we concern about .c 
files. The patch would be non-trivial. Please try the following command:

$ grep --color '[^_]false[^_]' *.c

Kamil