From: Kamil Dudka <kdudka@redhat.com>
To: Christopher Li <sparse@chrisli.org>
Cc: sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] make sparse headers self-compilable...
Date: Tue, 11 Aug 2009 23:25:48 +0200 [thread overview]
Message-ID: <200908112325.48345.kdudka@redhat.com> (raw)
In-Reply-To: <70318cbf0908111408u238bd057vd3e4578baa0fe32c@mail.gmail.com>
On Tuesday 11 of August 2009 23:08:24 Christopher Li wrote:
> On Tue, Aug 11, 2009 at 3:40 AM, Kamil Dudka<kdudka@redhat.com> wrote:
> > I agree processing of multiple-includes could be painful for the SPARSE
> > preprocessor. But you don't solve it by avoiding multiple-includes in the
> > SPARSE code itself. If you want to pass the SPARSE code through SPARSE,
> > it's small enough to not bother us with performance.
>
> I am worry about adding too much duplicated include slow down the
> gcc compile of sparse itself. I know I am paranoid :-)
Tested just now (ccache turned off)...
With the original (not amended) patch:
$ make clean && time make -j9
real 0m0.966s
user 0m4.654s
sys 0m1.471s
With the amended patch:
$ make clean && time make -j9
real 0m0.989s
user 0m4.580s
sys 0m1.504s
Without any of my patches applied:
$ make clean && time make -j9
real 0m0.980s
user 0m4.596s
sys 0m1.495s
Note that the results fluctuated approx 10% during runs.
My conclusion: absolutely no impact on gcc compile time.
Kamil
next prev parent reply other threads:[~2009-08-11 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 20:27 [PATCH] make sparse headers self-compilable Kamil Dudka
2009-08-08 11:10 ` Kamil Dudka
2009-08-11 9:40 ` Christopher Li
2009-08-11 9:55 ` Kamil Dudka
2009-08-11 10:40 ` Kamil Dudka
2009-08-11 21:08 ` Christopher Li
2009-08-11 21:25 ` Kamil Dudka [this message]
2009-08-11 12:48 ` Hannes Eder
2009-08-11 12:59 ` Kamil Dudka
2009-08-11 21:08 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908112325.48345.kdudka@redhat.com \
--to=kdudka@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).