From: Josh Triplett <josh@joshtriplett.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christopher Li <sparse@chrisli.org>,
linux-sparse@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] sparse: Add GCC pre-defined macros for user-space
Date: Sat, 15 Aug 2009 15:36:03 -0700 [thread overview]
Message-ID: <20090815223602.GA4516@feather> (raw)
In-Reply-To: <1250367991.14751.1.camel@penberg-laptop>
On Sat, Aug 15, 2009 at 11:26:31PM +0300, Pekka Enberg wrote:
> --- a/lib.c
> +++ b/lib.c
> @@ -788,6 +788,14 @@ void create_builtin_stream(void)
> add_pre_buffer("#define __OPTIMIZE__ 1\n");
> if (optimize_size)
> add_pre_buffer("#define __OPTIMIZE_SIZE__ 1\n");
> +
> + /* GCC defines these for limits.h */
> + add_pre_buffer("#weak_define __SHRT_MAX__ %d\n", __SHRT_MAX__);
> + add_pre_buffer("#weak_define __SCHAR_MAX__ %d\n", __SCHAR_MAX__);
> + add_pre_buffer("#weak_define __INT_MAX__ %d\n", __INT_MAX__);
> + add_pre_buffer("#weak_define __LONG_MAX__ %ld\n", __LONG_MAX__);
> + add_pre_buffer("#weak_define __LONG_LONG_MAX__ %lld\n", __LONG_LONG_MAX__);
> + add_pre_buffer("#weak_define __WCHAR_MAX__ %d\n", __WCHAR_MAX__);
These defines need to have the right type suffixes. GCC defines
__LONG_LONG_MAX__ with an LL suffix, and __LONG_MAX__ with an L suffix.
You could either add the appropriate suffixes, or better yet, stringize
the constants and print them as strings.
- Josh Triplett
next prev parent reply other threads:[~2009-08-15 22:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 14:57 [PATCH] sparse: Add GCC pre-defined macros for user-space Pekka Enberg
2009-08-15 19:36 ` Christopher Li
2009-08-15 20:26 ` Pekka Enberg
2009-08-15 22:36 ` Josh Triplett [this message]
2009-08-16 7:03 ` Pekka Enberg
2009-08-16 10:51 ` Josh Triplett
2009-08-16 11:05 ` Pekka Enberg
2009-08-16 12:41 ` Josh Triplett
2009-08-16 17:50 ` Christopher Li
2009-08-16 18:56 ` Josh Triplett
2009-08-16 19:34 ` Johannes Berg
2009-08-16 20:00 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090815223602.GA4516@feather \
--to=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).