On Wed March 10 2010 02:09:22 Pavel Roskin wrote: > I wonder is the quirk handling could be skipped for EXPR_SELECT, but I'm > fine with it if it's harmless. That's more likely question for sparse developers. I have no test-case which goes through the EXPR_SELECT path, so that I can't test it actually. > When would expr or type be NULL? Also no test-case here, but it's still better to skip the optional analysis than let it crash on invalid dereference. > We could check type in warn_for_enum_conversions(). Sure, I've just improved it. Thanks for the hint! Also the order of that patches has been reversed, so that they are less chatty. Kamil