From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: including sparse headers in C++ code Date: Tue, 19 Oct 2010 23:12:46 +0100 Message-ID: <20101019221246.GW19804@ZenIV.linux.org.uk> References: <20101016191153.GA19324@feather> <20101018053955.GA1628@feather> <20101019213109.GV19804@ZenIV.linux.org.uk> <1287524804.3483.26.camel@radiator.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:59946 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754600Ab0JSWNE (ORCPT ); Tue, 19 Oct 2010 18:13:04 -0400 Content-Disposition: inline In-Reply-To: <1287524804.3483.26.camel@radiator.bos.redhat.com> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: David Malcolm Cc: Tomas Klacko , Christopher Li , Josh Triplett , linux-sparse@vger.kernel.org On Tue, Oct 19, 2010 at 05:46:44PM -0400, David Malcolm wrote: > On Tue, 2010-10-19 at 22:31 +0100, Al Viro wrote: > > On Tue, Oct 19, 2010 at 10:03:42PM +0200, Tomas Klacko wrote: > > > @@ -188,7 +188,7 @@ static struct symbol_op char_op = { > > > .type = KW_SPECIFIER, > > > .test = Set_T|Set_Long|Set_Short, > > > .set = Set_T|Set_Char, > > > - .class = CChar, > > > + .klass = CChar, > > > }; > > > > Egads... Why not "kC1455", while you are at it? Seriously, if you feel the > > need to rename that, at least use something more palatable. Hell, even > > adjust_type would be better... > FWIW, "klass" is used as a spelling of "class" in .c code by Ruby, by > the GTK/GNOME stack, Mono, OpenJDK, Dalvik, and others. I'd say that it's an argument _against_ doing that, if anything...