From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: including sparse headers in C++ code Date: Wed, 20 Oct 2010 08:40:34 +0100 Message-ID: <20101020074034.GY19804@ZenIV.linux.org.uk> References: <20101016191153.GA19324@feather> <20101018053955.GA1628@feather> <20101019213109.GV19804@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:56202 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932162Ab0JTHkh (ORCPT ); Wed, 20 Oct 2010 03:40:37 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li Cc: Tomas Klacko , Josh Triplett , linux-sparse@vger.kernel.org On Tue, Oct 19, 2010 at 04:07:42PM -0700, Christopher Li wrote: > On Tue, Oct 19, 2010 at 2:31 PM, Al Viro wrote: > > On Tue, Oct 19, 2010 at 10:03:42PM +0200, Tomas Klacko wrote: > >> @@ -188,7 +188,7 @@ static struct symbol_op char_op = { > >> ? ? ? .type = KW_SPECIFIER, > >> ? ? ? .test = Set_T|Set_Long|Set_Short, > >> ? ? ? .set = Set_T|Set_Char, > >> - ? ? .class = CChar, > >> + ? ? .klass = CChar, > >> ?}; > > > > Egads... ?Why not "kC1455", while you are at it? ?Seriously, if you feel the > > need to rename that, at least use something more palatable. ?Hell, even > > adjust_type would be better... > > I suggested the "klass", my bad. How about your suggest a perfect name > and we will use it. Is "adjust_type" good enough? type_group, probably... FWIW, I'd probably spell that enum in parse.c as CInt = 0, CSInt = 1, CUInt = 2, CReal = 3, CChar = 4, CSChar = CChar + CSInt, CUChar = CChar + CUInt while we are at it.