From: Josh Triplett <josh@joshtriplett.org>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 1/3] evaluate: warn on identical exprs around '&&'
Date: Sat, 27 Aug 2011 19:50:10 -0700 [thread overview]
Message-ID: <20110828025010.GB20823@leaf> (raw)
In-Reply-To: <1314484015-7694-1-git-send-email-chrisf@ijw.co.nz>
On Sun, Aug 28, 2011 at 10:26:53AM +1200, Chris Forbes wrote:
> Adds a warning when identical expressions are found on both sides of the '&&' operator. This is a common error resulting from copy & paste.
>
> Excludes identical expressions found while preprocessing, so we don't get upset about #if defined(FOO) && defined(BAR), which happens all the time, and is perfectly valid.
>
> Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
Very nice patch series! I replied to patch 3 about a bit of patch cleanup, but otherwise this looks fine, and I've wanted to see this check for a while.
Would you consider also checking for identical expresions on both sides
of an &, |, or ^? The former two seem like likely cases when composing
flags, and the latter seems like a likely error as well.
Also, how does your patch handle expressions like this: *x++ && *x++
Or this: f() && f()
- Josh Triplett
next prev parent reply other threads:[~2011-08-28 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 22:26 [PATCH 1/3] evaluate: warn on identical exprs around '&&' Chris Forbes
2011-08-27 22:26 ` [PATCH 2/3] evaluate: warn on identical exprs around '||' Chris Forbes
2011-08-27 22:26 ` [PATCH 3/3] evaluate: warn on identical exprs on ?: Chris Forbes
2011-08-28 2:46 ` Josh Triplett
2011-08-28 2:51 ` Chris Forbes
2011-08-28 2:50 ` Josh Triplett [this message]
2011-08-28 2:53 ` [PATCH 1/3] evaluate: warn on identical exprs around '&&' Chris Forbes
2011-08-28 3:33 ` Josh Triplett
2011-08-28 2:57 ` Chris Forbes
2011-08-28 3:36 ` Josh Triplett
2011-08-31 0:24 ` Christopher Li
-- strict thread matches above, loose matches on Subject: below --
2011-08-28 3:14 Chris Forbes
2011-08-29 10:01 ` Jonathan Neuschäfer
2011-08-29 10:25 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110828025010.GB20823@leaf \
--to=josh@joshtriplett.org \
--cc=chrisf@ijw.co.nz \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).