From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 1/3] evaluate: warn on identical exprs around '&&'
Date: Mon, 29 Aug 2011 12:01:06 +0200 [thread overview]
Message-ID: <20110829100106.GE15022@debian.debian> (raw)
In-Reply-To: <1314501260-27254-1-git-send-email-chrisf@ijw.co.nz>
On Sun, Aug 28, 2011 at 03:14:18PM +1200, Chris Forbes wrote:
> + case EXPR_BINOP:
> + case EXPR_COMMA:
> + case EXPR_COMPARE:
> + case EXPR_LOGICAL:
> + case EXPR_ASSIGNMENT:
> + return expr_equiv(lhs->left, rhs->left) &&
> + expr_equiv(lhs->right, rhs->right);
[...]
> + if ((a == b) && (a == b)) /* should warn */
> + bar();
> +
> + if ((a == b) && (b == c)) /* should not warn */
> + bar();
Should it maybe also handle cases like this?
if ((a == b) && (b == a))
bar();
Thanks,
Jonathan Neuschäfer
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-29 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 3:14 [PATCH 1/3] evaluate: warn on identical exprs around '&&' Chris Forbes
2011-08-28 3:14 ` [PATCH 2/3] evaluate: warn on identical exprs around '||' Chris Forbes
2011-08-28 3:14 ` [PATCH 3/3] evaluate: warn on identical exprs on ?: Chris Forbes
2011-08-29 10:01 ` Jonathan Neuschäfer [this message]
2011-08-29 10:25 ` [PATCH 1/3] evaluate: warn on identical exprs around '&&' Josh Triplett
-- strict thread matches above, loose matches on Subject: below --
2011-08-27 22:26 Chris Forbes
2011-08-28 2:50 ` Josh Triplett
2011-08-28 2:53 ` Chris Forbes
2011-08-28 3:33 ` Josh Triplett
2011-08-28 2:57 ` Chris Forbes
2011-08-28 3:36 ` Josh Triplett
2011-08-31 0:24 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829100106.GE15022@debian.debian \
--to=j.neuschaefer@gmx.net \
--cc=chrisf@ijw.co.nz \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).