From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: Suggestion for fixing the variable length array used in the kernel. Date: Sat, 9 Mar 2013 08:39:00 +0300 Message-ID: <20130309053859.GY9138@mwanda> References: <20130308162922.88ad40997d01099949008452@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:38883 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756Ab3CIFjO (ORCPT ); Sat, 9 Mar 2013 00:39:14 -0500 Content-Disposition: inline In-Reply-To: <20130308162922.88ad40997d01099949008452@linux-foundation.org> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Andrew Morton Cc: Christopher Li , linux-kernel , Linux-Sparse , Linus Torvalds On Fri, Mar 08, 2013 at 04:29:22PM -0800, Andrew Morton wrote: > On Wed, 6 Mar 2013 20:46:35 -0800 Christopher Li wrote: > > > Hi, > > > > I am looking at the current sparse warning on the kernel source. > > One category of those warning are produce by the variable length array. > > We all know that the kernel stack has a limit so we don't want to allocate > > too much stack to the variable size array. > > > > Is there a recommended way to fix those warnings? Is it worth while to > > fix it at all? I am looking forward to some kind of guideline how to handle > > this. > > Roughly how many instances of this are there kernel-wide? > Around 150 on x86 allmodconfig. They are pretty well audited. regards, dan carpenter