From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Christopher Li <sparse@chrisli.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg Price <price@MIT.EDU>,
linux-sparse@vger.kernel.org,
linux-mtd <linux-mtd@lists.infradead.org>,
dwmw2 <dwmw2@infradead.org>, Erico Nunes <nunes.erico@gmail.com>
Subject: Re: [PATCH] Clarify error on directive in macro arguments (Re: [PATCH] jffs2: fix sparse errors: directive in argument list)
Date: Mon, 18 Nov 2013 02:34:43 +0000 [thread overview]
Message-ID: <20131118023443.GN13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1384740932.5814.4.camel@joe-AO722>
On Sun, Nov 17, 2013 at 06:15:32PM -0800, Joe Perches wrote:
> > > sparse matches gcc behaviour (I hope), but it warns about such abuses.
> > > It's a defect, all right - one being reported by sparse.
> >
> > Perhaps the following tweak to the error message would make this
> > subtlety clearer?
>
> Maybe, but this case isn't a macro. It's a function.
> Dunno if differentiating when it's a macro or a
> function is difficult though.
In which case? With printk() it's perfectly fine and sparse
will not complain at all. With pr_info(), OTOH, we have
#define pr_info(fmt, ...) \
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
and when you start playing that kind of games with it, you get warnings.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2013-11-18 2:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1384719513-27386-1-git-send-email-nunes.erico@gmail.com>
2013-11-17 21:40 ` [PATCH] jffs2: fix sparse errors: directive in argument list Joe Perches
2013-11-17 22:34 ` Erico Nunes
2013-11-17 22:43 ` Erico Nunes
2013-11-17 22:45 ` Joe Perches
2013-11-17 22:53 ` Richard Weinberger
2013-11-18 1:33 ` Al Viro
2013-11-18 2:07 ` [PATCH] Clarify error on directive in macro arguments (Re: [PATCH] jffs2: fix sparse errors: directive in argument list) Greg Price
2013-11-18 2:15 ` Joe Perches
2013-11-18 2:23 ` Erico Nunes
2013-11-18 2:34 ` Al Viro [this message]
2013-11-18 4:01 ` Greg Price
2013-11-20 23:53 ` Josh Triplett
2013-11-20 23:51 ` [PATCH] jffs2: fix sparse errors: directive in argument list Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118023443.GN13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dwmw2@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sparse@vger.kernel.org \
--cc=nunes.erico@gmail.com \
--cc=price@MIT.EDU \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).