From: Andi Kleen <ak@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wei Yongjun <weiyj.lk@gmail.com>, linux-sparse@vger.kernel.org
Subject: Re: [BUG] sparse warning EXPORT_SYMBOL()'d symbol non-static
Date: Sun, 24 Nov 2013 12:28:51 -0800 [thread overview]
Message-ID: <20131124202851.GF19762@tassilo.jf.intel.com> (raw)
In-Reply-To: <1385322581.23961.5.camel@jlt4.sipsolutions.net>
> Well, sparse is clearly "right", for all it cares it might very well be
> static, but it seems this is necessary for something in the kernel and
> we clearly can't forward-declare it in a header file. Perhaps we can add
> some annotation to say
> "__attribute__((yes_I_know_but_really_dont_want_this_to_be_static))" to
> suppress this warning? This is getting annoying to me as well :-)
We could do something like
typeof(foo);
in the macro. Not sure if that would make sparse happy.
Also this is really working around a problem upto gcc 4.8. that was fixed
in gcc 4.9 (adding numerical postfixes to all symbols) If it's ok to let LTO only support 4.9+ the patches could be reverted.
-Andi
next prev parent reply other threads:[~2013-11-24 20:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 6:46 [BUG] sparse warning EXPORT_SYMBOL()'d symbol non-static Wei Yongjun
2013-11-24 19:49 ` Johannes Berg
2013-11-24 20:28 ` Andi Kleen [this message]
2013-11-24 20:36 ` Johannes Berg
2013-11-24 20:45 ` Josh Triplett
2013-11-24 20:48 ` Johannes Berg
2013-11-24 20:52 ` Johannes Berg
2013-11-24 22:34 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131124202851.GF19762@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-sparse@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).