Warn for extern prototypes

Warn for extern prototypes

[Sam Ravnborg]

Hi all.

Is it possible to get a warning when sparse encounter a
function prototype declared using "extern"?

So the following code:

extern void foo(void);
void bar(int x);

Would generate warnings because the declaration of foo()
uses extern.


I took a very short peek at evaluate.c - but decided to ask as maybe
there is already something that I overlooked or it is maybe trivial.

The rationale behind this is that at least in some areas of the kernel,
the use of "extern" for prototypes are no longer accepted.
A sparse warnings would be good to tell me all the cases I missed
in the conversion.

	Sam

Re: Warn for extern prototypes

[Dan Carpenter]

On Wed, Apr 30, 2014 at 10:07:30PM +0200, Sam Ravnborg wrote:
> The rationale behind this is that at least in some areas of the kernel,
> the use of "extern" for prototypes are no longer accepted.
> A sparse warnings would be good to tell me all the cases I missed
> in the conversion.

Doesn't checkpatch.pl already check for this?

regards,
dan carpenter

Re: Warn for extern prototypes

[Sam Ravnborg]

On Wed, Apr 30, 2014 at 11:30:57PM +0300, Dan Carpenter wrote:
> On Wed, Apr 30, 2014 at 10:07:30PM +0200, Sam Ravnborg wrote:
> > The rationale behind this is that at least in some areas of the kernel,
> > the use of "extern" for prototypes are no longer accepted.
> > A sparse warnings would be good to tell me all the cases I missed
> > in the conversion.
> 
> Doesn't checkpatch.pl already check for this?
checkpatch --strict -f foo.h will include this check.

But then there are so much other noise...

It is much simpler to do:

   make C=2 arch/sparc/

and the process the sparse warnings.

	Sam