linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] lib.c: skip --param parameters
Date: Mon, 16 Jun 2014 09:02:38 -0700	[thread overview]
Message-ID: <20140616160238.GA2746@jtriplet-mobl1> (raw)
In-Reply-To: <1402915386-28210-1-git-send-email-andriy.shevchenko@linux.intel.com>

On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote:
> Very dumb patch to just skip --param allow-store-data-races=0 introduced in
> newest Linux kernel buildsystem.
> 
> Actually the option is present in few GCC versions and probably should be
> handled properly.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

As far as I can tell, this seems to only handle "--param arg"; however,
according to the thread on LKML, GCC handles --param=arg as well.  Could
you please handle that variant too?

>  lib.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib.c b/lib.c
> index bf3e91c..e56037b 100644
> --- a/lib.c
> +++ b/lib.c
> @@ -673,6 +673,12 @@ static char **handle_version(char *arg, char **next)
>  	exit(0);
>  }
>  
> +static char **handle_param(char *arg, char **next)
> +{
> +	++next;
> +	return ++next;
> +}
> +
>  struct switches {
>  	const char *name;
>  	char **(*fn)(char *, char **);
> @@ -681,6 +687,7 @@ struct switches {
>  static char **handle_long_options(char *arg, char **next)
>  {
>  	static struct switches cmd[] = {
> +		{ "param", handle_param },
>  		{ "version", handle_version },
>  		{ NULL, NULL }
>  	};
> -- 
> 2.0.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-06-16 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 10:43 [PATCH] lib.c: skip --param parameters Andy Shevchenko
2014-06-16 16:02 ` Josh Triplett [this message]
2014-06-16 23:48   ` David Rientjes
2014-06-17  2:36     ` Josh Triplett
2014-06-17  8:15   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140616160238.GA2746@jtriplet-mobl1 \
    --to=josh@joshtriplett.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).