From: Josh Triplett <josh@joshtriplett.org>
To: David Rientjes <rientjes@google.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] lib.c: skip --param parameters
Date: Mon, 16 Jun 2014 19:36:48 -0700 [thread overview]
Message-ID: <20140617023648.GA5961@thin> (raw)
In-Reply-To: <alpine.DEB.2.02.1406161647510.21018@chino.kir.corp.google.com>
On Mon, Jun 16, 2014 at 04:48:51PM -0700, David Rientjes wrote:
> On Mon, 16 Jun 2014, Josh Triplett wrote:
>
> > On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote:
> > > Very dumb patch to just skip --param allow-store-data-races=0 introduced in
> > > newest Linux kernel buildsystem.
> > >
> > > Actually the option is present in few GCC versions and probably should be
> > > handled properly.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > As far as I can tell, this seems to only handle "--param arg"; however,
> > according to the thread on LKML, GCC handles --param=arg as well. Could
> > you please handle that variant too?
> >
>
> This is only from linux-next and not Linus's tree, correct?
>
> Is this still necessary since the "./Makefile: tell gcc optimizer to never
> introduce new data races" patch has been removed from -mm due to failures?
>
> See http://marc.info/?l=linux-mm-commits&m=140295825623471
I'd still like to see Sparse not choke on the option, in either form,
whether the kernel ends up using it or not.
- Josh Triplett
next prev parent reply other threads:[~2014-06-17 2:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 10:43 [PATCH] lib.c: skip --param parameters Andy Shevchenko
2014-06-16 16:02 ` Josh Triplett
2014-06-16 23:48 ` David Rientjes
2014-06-17 2:36 ` Josh Triplett [this message]
2014-06-17 8:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617023648.GA5961@thin \
--to=josh@joshtriplett.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).