From: Josh Triplett <josh@joshtriplett.org>
To: NeilBrown <neilb@suse.de>
Cc: akpm@linux-foundation.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christopher Li <sparse@chrisli.org>,
Ingo Molnar <mingo@redhat.com>,
Jeff Layton <jlayton@poochiereds.net>,
Michal Marek <mmarek@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/5] raid: Require designated initialization of structures
Date: Thu, 31 Jul 2014 18:30:30 -0700 [thread overview]
Message-ID: <20140801013030.GA20935@thin> (raw)
In-Reply-To: <20140801111055.59419950@notabene.brown>
On Fri, Aug 01, 2014 at 11:10:55AM +1000, NeilBrown wrote:
> On Thu, 31 Jul 2014 16:47:35 -0700 Josh Triplett <josh@joshtriplett.org>
> wrote:
>
> > Mark raid6_calls and other structures containing function pointers with
> > __designated_init. Fix implementations in lib/raid6/ to use designated
> > initializers; this also simplifies those initializers using the default
> > initialization of fields to 0.
> >
> > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
>
> Looks like an excellent idea!
> Feel free to forward this upstream on my behalf, or remind me once the first
> patch is in -next, and I'll take this one myself - whichever you prefer.
>
> Acked-by: NeilBrown <neilb@suse.de>
Thanks! Ideally, I'd like to see the whole series go in through one
tree, which is why I CCed Andrew. I can easily produce several dozen
more patches like these, but I just included enough examples to motivate
patch 1, and I can send more in any order once that one goes in.
- Josh Triplett
next prev parent reply other threads:[~2014-08-01 1:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 23:47 [PATCH 1/5] Add __designated_init, wrapping __attribute__((designated_init)) Josh Triplett
2014-07-31 23:47 ` [PATCH 2/5] raid: Require designated initialization of structures Josh Triplett
[not found] ` <1d468224409ef2bf46874f817d19389ac5d1b26d.1406850006.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2014-08-01 1:10 ` NeilBrown
2014-08-01 1:30 ` Josh Triplett [this message]
2014-07-31 23:47 ` [PATCH 3/5] fs: " Josh Triplett
2014-07-31 23:47 ` [PATCH 4/5] ftrace: " Josh Triplett
2014-07-31 23:48 ` [PATCH 5/5] include/linux/interrupt.h: " Josh Triplett
[not found] ` <3130b0553b15518e3bef6d14c80280beed0f5ff9.1406850006.git.josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
2014-08-01 20:45 ` [PATCH 1/5] Add __designated_init, wrapping __attribute__((designated_init)) Andrew Morton
2014-08-01 21:36 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801013030.GA20935@thin \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=neilb@suse.de \
--cc=rostedt@goodmis.org \
--cc=sparse@chrisli.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).