From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] sched: Remove nested extern Date: Mon, 22 Sep 2014 23:21:05 +0200 Message-ID: <20140922212105.GD3128@worktop.programming.kicks-ass.net> References: <20140922175511.62229.98784.stgit@mdrustad-wks.jf.intel.com> <20140922190128.GA2805@worktop.programming.kicks-ass.net> <20140922200527.GA3128@worktop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:60031 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbaIVVVM (ORCPT ); Mon, 22 Sep 2014 17:21:12 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: "Rustad, Mark D" Cc: "sparse@chrisli.org" , "linux-kernel@vger.kernel.org" , "richard.weinberger@gmail.com" , "linux-sparse@vger.kernel.org" , "mingo@redhat.com" , "Kirsher, Jeffrey T" , "computersforpeace@gmail.com" On Mon, Sep 22, 2014 at 08:59:32PM +0000, Rustad, Mark D wrote: > Because I have found that enabling many warnings helps identify problems > in code and it has been my standard practice since about 1999 to do so. > The compiler warnings are really just another form of static analysis, > and I use it routinely on every compile. Here is how routinely: I have > W=1 in my environment, W=12 is just too painful. I would change that > default to W=12 if it wasn't insane to do so. Many warnings are just plain insane and stupid. They're not helping anybody. There's a very good reason many are disabled. I'm sure you can find some entertaining discussions on the topic if you search the LKML archives.