From: Thomas Graf <tgraf@suug.ch>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] sparse: Make -Werror turn warnigns into errors
Date: Wed, 24 Sep 2014 16:42:07 +0100 [thread overview]
Message-ID: <20140924154207.GD4966@casper.infradead.org> (raw)
In-Reply-To: <CANeU7QnRFxZ+OV5G2W3tC+tBnYNNcQsH_YEB=cyHmAfmfYc1PQ@mail.gmail.com>
On 09/24/14 at 11:24pm, Christopher Li wrote:
> In stead of patching each test case file. How about teach the
> test-suilte to be smarter? The test-suilte should change the default
> return value to none zero if there is none empty "check-error-start" and
> "check-error-end" section. In other words, if there is expected
> error output, we already guess the returns status is error.
> The test case can still use "check-exit-value" to overwrite the default
> value.
>
> I expect that can save most of the patching to test case file.
The return value of thest will only be non zero if an actual error
has been detected. It will remain zero if only warnings have been
found. So we would need to parse the text between "check-exit-start"
and "check-error-end" for the string "error:" or something a like
that. I found that to be fragile and the explicit declaration of an
expected failure to be superior as it also verifies whether an
expected warning is properly treated as a warning or not.
next prev parent reply other threads:[~2014-09-24 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 18:54 [PATCH] sparse: Make -Werror turn warnigns into errors Thomas Graf
2014-09-03 18:59 ` josh
2014-09-03 19:08 ` Thomas Graf
2014-09-24 12:31 ` Sparse maintainership (was: [PATCH] sparse: Make -Werror turn warnigns into errors) Thomas Graf
2014-09-24 15:05 ` Christopher Li
2014-09-24 15:24 ` [PATCH] sparse: Make -Werror turn warnigns into errors Christopher Li
2014-09-24 15:42 ` Thomas Graf [this message]
2014-09-24 23:16 ` Christopher Li
2014-09-25 2:27 ` Christopher Li
2014-09-25 2:46 ` Christopher Li
2014-09-25 8:12 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924154207.GD4966@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).