* [PATCH] sparse: Fix ioc type check @ 2014-09-25 8:20 Thomas Graf 2014-09-25 12:10 ` Christopher Li 0 siblings, 1 reply; 3+ messages in thread From: Thomas Graf @ 2014-09-25 8:20 UTC (permalink / raw) To: linux-sparse; +Cc: hans.verkuil, sparse Add missing exepcted error output for the test to pass. Fixes: 42ebe41 "Add test case for the ioc type check" Signed-off-by: Thomas Graf <tgraf@suug.ch> --- validation/ioc-typecheck.c | 1 + 1 file changed, 1 insertion(+) diff --git a/validation/ioc-typecheck.c b/validation/ioc-typecheck.c index aa060f7..baa200a 100644 --- a/validation/ioc-typecheck.c +++ b/validation/ioc-typecheck.c @@ -13,5 +13,6 @@ static unsigned iocnrs[] = { * check-name: correct handling of _IOC_TYPECHECK * * check-error-start +ioc-typecheck.c:10:21: error: bad integer constant expression * check-error-end */ -- 1.9.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sparse: Fix ioc type check 2014-09-25 8:20 [PATCH] sparse: Fix ioc type check Thomas Graf @ 2014-09-25 12:10 ` Christopher Li 2014-09-25 12:30 ` Thomas Graf 0 siblings, 1 reply; 3+ messages in thread From: Christopher Li @ 2014-09-25 12:10 UTC (permalink / raw) To: Thomas Graf; +Cc: Linux-Sparse, hans.verkuil On Thu, Sep 25, 2014 at 4:20 PM, Thomas Graf <tgraf@suug.ch> wrote: > Add missing exepcted error output for the test to pass. > > Fixes: 42ebe41 "Add test case for the ioc type check" > Signed-off-by: Thomas Graf <tgraf@suug.ch> No, this test case is some thing gcc can handle and sparse can't. Instead of patching the test result, we need to fix sparse to handle it correctly. It is an open bug of sparse. Chris ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparse: Fix ioc type check 2014-09-25 12:10 ` Christopher Li @ 2014-09-25 12:30 ` Thomas Graf 0 siblings, 0 replies; 3+ messages in thread From: Thomas Graf @ 2014-09-25 12:30 UTC (permalink / raw) To: Christopher Li; +Cc: Linux-Sparse, hans.verkuil On 09/25/14 at 08:10pm, Christopher Li wrote: > No, this test case is some thing gcc can handle and sparse > can't. Instead of patching the test result, we need to fix sparse > to handle it correctly. > > It is an open bug of sparse. OK. This was not clear from the commit message. Thanks for clarifying. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-25 12:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-25 8:20 [PATCH] sparse: Fix ioc type check Thomas Graf 2014-09-25 12:10 ` Christopher Li 2014-09-25 12:30 ` Thomas Graf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).