From: Josh Triplett <josh@joshtriplett.org>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: linux-sparse@vger.kernel.org, dan.carpenter@oracle.com,
sparse@chrisli.org
Subject: Re: [PATCH] Link binaries with system libraries needed by LLVM
Date: Thu, 2 Oct 2014 12:53:23 -0700 [thread overview]
Message-ID: <20141002195322.GB3528@jtriplet-mobl1> (raw)
In-Reply-To: <1412259588-8542-1-git-send-email-anatol.pomozov@gmail.com>
On Thu, Oct 02, 2014 at 07:19:48AM -0700, Anatol Pomozov wrote:
> It is needed on Linux Arch with latest LLVM installed
>
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
One comment below.
> Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 28c4df6..25087d7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -112,11 +112,12 @@ LLVM_PROGS := sparse-llvm
> $(LLVM_PROGS): LD := g++
> LLVM_LDFLAGS := $(shell llvm-config --ldflags)
> LLVM_CFLAGS := $(shell llvm-config --cflags | sed -e "s/-DNDEBUG//g")
> +LLVM_SYSTEM_LIBS := $(shell llvm-config --system-libs)
> LLVM_LIBS := $(shell llvm-config --libs)
> PROGRAMS += $(LLVM_PROGS)
> INST_PROGRAMS += sparse-llvm sparsec
> sparse-llvm.o: BASIC_CFLAGS += $(LLVM_CFLAGS)
> -sparse-llvm_EXTRA_OBJS := $(LLVM_LIBS) $(LLVM_LDFLAGS)
> +sparse-llvm_EXTRA_OBJS := $(LLVM_SYSTEM_LIBS) $(LLVM_LIBS) $(LLVM_LDFLAGS)
Does llvm-config support passing multiple options, such as "llvm-config
--libs --system-libs"? If so, I'd suggest just adding --system-libs to
the call in LLVM_LIBS, rather than adding a second variable.
(It's obnoxious that llvm requires its own configuration tool rather
than using pkg-config.)
- Josh Triplett
next prev parent reply other threads:[~2014-10-02 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:19 [PATCH] Link binaries with system libraries needed by LLVM Anatol Pomozov
2014-10-02 19:53 ` Josh Triplett [this message]
2014-10-02 20:05 ` Anatol Pomozov
2014-10-02 20:09 ` Anatol Pomozov
2014-10-02 20:11 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002195322.GB3528@jtriplet-mobl1 \
--to=josh@joshtriplett.org \
--cc=anatol.pomozov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox