From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: linux-sparse@vger.kernel.org, sparse@chrisli.org
Subject: Re: [PATCH v2] sparse: Make -Werror turn warnigns into errors
Date: Tue, 7 Oct 2014 12:45:08 +0300 [thread overview]
Message-ID: <20141007094508.GN23154@mwanda> (raw)
In-Reply-To: <795aaa7448d91bd59bcbea3d8e49b068a569409e.1411632579.git.tgraf@suug.ch>
> diff --git a/cgcc b/cgcc
> index c075e5f..204bda3 100755
> --- a/cgcc
> +++ b/cgcc
> @@ -70,7 +70,7 @@ if ($do_check) {
>
> print "$check\n" if $verbose;
> if ($do_compile) {
> - system ($check);
> + system ($check) == 0 or die;
This just enables -Werror for everyone so now I can't run Sparse on
itself now because there are old errors from 2007.
lib.c:192:6: error: symbol 'error_die' redeclared with different type (originally declared at lib.h:97) - different modifiers
lib.c:201:6: error: symbol 'die' redeclared with different type (originally declared at lib.h:93) - different modifiers
Btw, these errors also disable warnings for the rest of the file... I
don't think just because there are different modifiers it means that
we should give up looking for other warnings. In the kernel we miss
some endian bugs because of this.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-07 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:11 [PATCH v2] sparse: Make -Werror turn warnigns into errors Thomas Graf
2014-09-27 0:24 ` Christopher Li
2014-09-27 7:11 ` Thomas Graf
2014-09-28 2:32 ` Christopher Li
2014-10-07 9:45 ` Dan Carpenter [this message]
2014-10-08 9:39 ` Thomas Graf
2014-10-08 17:51 ` Christopher Li
2014-10-09 0:56 ` Ramsay Jones
2014-10-08 10:26 ` Christopher Li
2014-10-08 19:27 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007094508.GN23154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).