Re: [PATCH v2] sparse: Make -Werror turn warnigns into errors

[Thomas Graf <tgraf@suug.ch>]

On 10/07/14 at 12:45pm, Dan Carpenter wrote:
> > diff --git a/cgcc b/cgcc
> > index c075e5f..204bda3 100755
> > --- a/cgcc
> > +++ b/cgcc
> > @@ -70,7 +70,7 @@ if ($do_check) {
> >  
> >      print "$check\n" if $verbose;
> >      if ($do_compile) {
> > -	system ($check);
> > +	system ($check) == 0 or die;
> 
> This just enables -Werror for everyone so now I can't run Sparse on
> itself now because there are old errors from 2007.

The above change should merely have sparse fail upon an error and not
warnings unless you specifiy -Werror which I would consider expected
behaviour.

> lib.c:192:6: error: symbol 'error_die' redeclared with different type (originally declared at lib.h:97) - different modifiers
> lib.c:201:6: error: symbol 'die' redeclared with different type (originally declared at lib.h:93) - different modifiers
> 
> Btw, these errors also disable warnings for the rest of the file...  I
> don't think just because there are different modifiers it means that
> we should give up looking for other warnings.  In the kernel we miss
> some endian bugs because of this.