From: josh@joshtriplett.org
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Christopher Li <sparse@chrisli.org>
Subject: Re: [PATCH] Support __COUNTER__ macro
Date: Fri, 23 Jan 2015 14:39:41 -0800 [thread overview]
Message-ID: <20150123223941.GC1489@cloud> (raw)
In-Reply-To: <20150123222644.GA691@ravnborg.org>
On Fri, Jan 23, 2015 at 11:26:44PM +0100, Sam Ravnborg wrote:
> + } else if (token->ident == &__COUNTER__ident) {
> + static int counter = 0;
> + replace_with_integer(token, counter++);
Same comment as with the other version of this patch: this shouldn't use
a static counter, because it needs to reset for each top-level source
file.
- Josh Triplett
prev parent reply other threads:[~2015-01-23 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 22:26 [PATCH] Support __COUNTER__ macro Sam Ravnborg
2015-01-23 22:39 ` josh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123223941.GC1489@cloud \
--to=josh@joshtriplett.org \
--cc=borntraeger@de.ibm.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).