From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
Linux-Sparse <linux-sparse@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Teach sparse about the __COUNTER__ predefined macro
Date: Wed, 4 Feb 2015 03:38:18 +0100 [thread overview]
Message-ID: <20150204023816.GA7731@macpro.local> (raw)
In-Reply-To: <CANeU7Qn9ORJ=uH6szkW2FpTT8hFhdNETjxndBYa8347Z1iON0Q@mail.gmail.com>
On Sun, Feb 01, 2015 at 09:17:38PM -0800, Christopher Li wrote:
> On Fri, Jan 23, 2015 at 3:59 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > Thanks for bringing to my attention.
> >
> > Here is a new version of the patch taking care of that.
> >
>
> I like Sam's commit message better. So I merge a version using his
> commit message.
>
> The branch for review is here:
> https://git.kernel.org/cgit/devel/sparse/chrisl/sparse.git/log/?h=review-counter
>
> If there is no objects, I will merge it to master.
>
> Chris
> --
Fine for me but Josh had a remark about the third test file (validation/preprocessor/counter3.c)
abusing a bit the test framework and I shared his feeling.
Here is a patch serie fixing this abuse by extending the test framework.
1/3) test-suite: add support for tests case involving several input files
2/3) test-suite: allow filename expansion of the input sections
3/3) test-suite: consolidate tests that require include files into single test files
Documentation/test-suite | 11 +++++++++++
validation/.gitignore | 1 +
validation/pragma-once.c | 13 ++++++++++++-
validation/preprocessor/counter2.c | 16 +++++++++++-----
validation/preprocessor/counter2.h | 1 -
validation/preprocessor/counter3.c | 15 +++++++++++----
validation/preprocessor/preprocessor20.c | 18 +++++++++++++++---
validation/preprocessor/preprocessor20.h | 6 ------
validation/test-suite | 11 +++++++++++
validation/test-suite-file-expansion.c | 22 ++++++++++++++++++++++
10 files changed, 94 insertions(+), 20 deletions(-)
next prev parent reply other threads:[~2015-02-04 2:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 20:31 sparse: new feature " multiple initializers" has false positives on MODULE_ALIAS Christian Borntraeger
2015-01-23 16:40 ` Christopher Li
2015-01-23 22:23 ` [PATCH] Teach sparse about the __COUNTER__ predefined macro Luc Van Oostenryck
2015-01-23 22:28 ` Sam Ravnborg
2015-01-23 22:38 ` josh
2015-01-23 23:59 ` Luc Van Oostenryck
2015-01-24 1:29 ` Josh Triplett
2015-01-24 11:27 ` Luc Van Oostenryck
2015-01-24 20:19 ` Josh Triplett
2015-01-24 20:39 ` Luc Van Oostenryck
2015-01-25 20:12 ` Christian Borntraeger
2015-01-28 10:08 ` Christian Borntraeger
2015-02-02 5:17 ` Christopher Li
2015-02-04 2:38 ` Luc Van Oostenryck [this message]
2015-02-12 20:16 ` Christopher Li
2015-02-04 2:46 ` [PATCH 1/3] test-suite: add support for tests case involving several input files Luc Van Oostenryck
2015-02-06 15:02 ` Christopher Li
2015-02-04 2:49 ` [PATCH 2/3] test-suite: allow filename expansion of the input sections Luc Van Oostenryck
2015-02-04 2:51 ` [PATCH 3/3] test-suite: consolidate tests that require include files into single test files Luc Van Oostenryck
2015-02-04 3:11 ` [PATCH 2/3] test-suite: allow filename expansion of the input sections Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204023816.GA7731@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).