From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
Linux-Sparse <linux-sparse@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH 1/3] test-suite: add support for tests case involving several input files
Date: Wed, 4 Feb 2015 03:46:26 +0100 [thread overview]
Message-ID: <20150204024625.GB7731@macpro.local> (raw)
In-Reply-To: <CANeU7Qn9ORJ=uH6szkW2FpTT8hFhdNETjxndBYa8347Z1iON0Q@mail.gmail.com>
These input files, instead of being stored in real files and thus polluting/confusing
the test framework are now placed in a serie of sections inside an unique test file.
These sections are delimited by new tags: input-file-1-start / input-file-1-end, / input-file-2-start/ ...
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Inspired-by: Josh Triplett <josh@joshtriplett.org>
---
Documentation/test-suite | 7 +++++++
validation/.gitignore | 1 +
validation/preprocessor/counter3.c | 15 +++++++++++----
validation/test-suite | 9 +++++++++
4 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/Documentation/test-suite b/Documentation/test-suite
index 6c4f24f6..e2ce7003 100644
--- a/Documentation/test-suite
+++ b/Documentation/test-suite
@@ -32,6 +32,10 @@ check-output-start / check-output-end (optional)
check-known-to-fail (optional)
Mark the test as being known to fail.
+input-file-1-start / input-file-1-end, / input-file-2-start/ ... (optional)
+ The input files of check-command lies between those two tags.
+ It's only needed when a test requires several files.
+
Using test-suite
~~~~~~~~~~~~~~~~
@@ -58,6 +62,9 @@ name:
cmd:
check-command value. If no cmd is provided, it defaults to
"sparse $file".
+ If the "input-file-1-start/..." tags are used those files are to be
+ referenced with "$file1", ... and the command need to be something like:
+ "sparse $file1 $file2"
The output of the test-suite format command can be redirected into the
test case to create a test-suite formated file.
diff --git a/validation/.gitignore b/validation/.gitignore
index 77276ba4..2a5f114b 100644
--- a/validation/.gitignore
+++ b/validation/.gitignore
@@ -2,3 +2,4 @@
*.diff
*.got
*.expected
+*.input[1-9]
diff --git a/validation/preprocessor/counter3.c b/validation/preprocessor/counter3.c
index 1449b2d1..76635e82 100644
--- a/validation/preprocessor/counter3.c
+++ b/validation/preprocessor/counter3.c
@@ -1,13 +1,20 @@
+/* input-file-1-start */
+__COUNTER__
+__COUNTER__
+/* input-file-1-end */
+
+/* input-file-2-start */
+__COUNTER__
+/* input-file-2-end */
+
/*
* check-name: __COUNTER__ #3
- * check-command: sparse -Ipreprocessor -E preprocessor/counter1.c preprocessor/counter2.c
+ * check-command: sparse -E $file1 $file2
*
* check-output-start
0
1
-"preprocessor/counter2.c" 0
-"preprocessor/counter2.h" 1
-"preprocessor/counter2.c" 2
+0
* check-output-end
*/
diff --git a/validation/test-suite b/validation/test-suite
index df5a7c60..97d4dd40 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -102,6 +102,15 @@ do_test()
fi
test_name=$last_result
+ # grab the input sections
+ input_nr=1
+ while grep -q "input-file-$input_nr-start" "$file"; do
+ sed -n "/input-file-$input_nr-start/,/input-file-$input_nr-end/p" "$file" \
+ | grep -v input-file > "$file".input$input_nr
+ eval "file$input_nr=$file.input$input_nr"
+ input_nr=$(($input_nr + 1))
+ done
+
# does the test provide a specific command ?
cmd=`eval echo $default_path/$default_cmd`
get_value "check-command" $file
--
2.2.0
next prev parent reply other threads:[~2015-02-04 2:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 20:31 sparse: new feature " multiple initializers" has false positives on MODULE_ALIAS Christian Borntraeger
2015-01-23 16:40 ` Christopher Li
2015-01-23 22:23 ` [PATCH] Teach sparse about the __COUNTER__ predefined macro Luc Van Oostenryck
2015-01-23 22:28 ` Sam Ravnborg
2015-01-23 22:38 ` josh
2015-01-23 23:59 ` Luc Van Oostenryck
2015-01-24 1:29 ` Josh Triplett
2015-01-24 11:27 ` Luc Van Oostenryck
2015-01-24 20:19 ` Josh Triplett
2015-01-24 20:39 ` Luc Van Oostenryck
2015-01-25 20:12 ` Christian Borntraeger
2015-01-28 10:08 ` Christian Borntraeger
2015-02-02 5:17 ` Christopher Li
2015-02-04 2:38 ` Luc Van Oostenryck
2015-02-12 20:16 ` Christopher Li
2015-02-04 2:46 ` Luc Van Oostenryck [this message]
2015-02-06 15:02 ` [PATCH 1/3] test-suite: add support for tests case involving several input files Christopher Li
2015-02-04 2:49 ` [PATCH 2/3] test-suite: allow filename expansion of the input sections Luc Van Oostenryck
2015-02-04 2:51 ` [PATCH 3/3] test-suite: consolidate tests that require include files into single test files Luc Van Oostenryck
2015-02-04 3:11 ` [PATCH 2/3] test-suite: allow filename expansion of the input sections Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204024625.GB7731@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).