linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Azat Khuzhin <a3at.mail@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Sparse ML <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 1/2] sparse, llvm: compile: skip function prototypes to avoid SIGSEGV
Date: Fri, 12 Jun 2015 08:18:06 +0300	[thread overview]
Message-ID: <20150612051806.GD29381@azat> (raw)
In-Reply-To: <CANeU7Q=VgqNhSDdQzF1H0pUjs78axBGz0VLjG2RY80P6aFh-_A@mail.gmail.com>

On Thu, Jun 11, 2015 at 05:50:16PM -0700, Christopher Li wrote:
> On Sat, May 16, 2015 at 3:32 PM, Azat Khuzhin <a3at.mail@gmail.com> wrote:
> >
> > You can't pass function to LLVMConstNull(), according to
> > Constant::getNullValue, and sparse-llvm already handle functions differently
> > (i.e. there will be no call to LLVMConstNull(), but this is not true for
> 
> 
> The patch looks good. I am applying it. However I just notice that you did not
> provide the signed-off-by line.
> 
> Can you resend both patch with the signed off line?

Sure, I'm doing this right now!

Thanks,
Azat.

  reply	other threads:[~2015-06-12  5:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16 22:32 [PATCH 0/2] sparse-llvm: avoid SIGSEGV for function prototypes Azat Khuzhin
2015-05-16 22:32 ` [PATCH 1/2] sparse, llvm: compile: skip function prototypes to avoid SIGSEGV Azat Khuzhin
2015-06-12  0:50   ` Christopher Li
2015-06-12  5:18     ` Azat Khuzhin [this message]
2015-05-16 22:32 ` [PATCH 2/2] validation/prototype: regression for skipping prototypes Azat Khuzhin
2015-05-17 18:40   ` Jonathan Neuschäfer
2015-05-17 18:53     ` Azat Khuzhin
2015-06-12  5:20 ` [PATCH 1/2 v2] sparse, llvm: compile: skip function prototypes to avoid SIGSEGV Azat Khuzhin
2015-06-12  5:20   ` [PATCH 2/2 v2] validation/prototype: regression for skipping prototypes Azat Khuzhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150612051806.GD29381@azat \
    --to=a3at.mail@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).