From: Sam Ravnborg <sam@ravnborg.org>
To: Tony Camuso <tcamuso@redhat.com>
Cc: josh@joshtriplett.org, linux-sparse@vger.kernel.org, sparse@chrisli.org
Subject: Re: [PATCH 3/3 V3] Add Wall_off switch to disable errors and warnings
Date: Sat, 1 Aug 2015 14:59:38 +0200 [thread overview]
Message-ID: <20150801125938.GA23735@ravnborg.org> (raw)
In-Reply-To: <1438370879-21792-1-git-send-email-tcamuso@redhat.com>
> diff --git a/parse.c b/parse.c
> index 02275d8..d70dffb 100644
> --- a/parse.c
> +++ b/parse.c
> @@ -2746,6 +2746,10 @@ struct token *external_declaration(struct token *token, struct symbol_list **lis
>
> /* Just a type declaration? */
> if (!ident) {
> +
> + if (Wall_off)
> + return token->next;
> +
> warning(token->pos, "missing identifier in declaration");
> return expect(token, ';', "at the end of type declaration");
This is on the wrong level.
You need to silence sparse in the spare_error function.
Not on the level where you do the expect() - otherwise you would
have to sprinkle "if (Wall_off)" checks everywhere.
This was also a problem in v1 of the patch.
Sam
next prev parent reply other threads:[~2015-08-01 13:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 0:26 [PATCH 0/3] Minor enhancements and fixes Tony Camuso
2015-07-30 0:26 ` [PATCH 1/3] .gitignore: add cscope and Qt project files Tony Camuso
2015-08-03 17:41 ` [PATCH 1/3 v2] " Tony Camuso
2015-08-08 3:58 ` Christopher Li
2015-08-10 11:18 ` Tony Camuso
2015-08-10 12:33 ` [PATCH 1/3 v3] " Tony Camuso
2015-07-30 0:26 ` [PATCH 2/3] c2xml.c, parse.c: gcc 5+ stricter case statement parsing Tony Camuso
2015-08-04 12:06 ` [PATCH 2/3 v2] Handle all enum members in case statements Tony Camuso
2015-08-04 23:31 ` Christopher Li
2015-08-04 23:52 ` Tony Camuso
[not found] ` <CANeU7Q=QAtRqDP36k8uOd9_XgzqjJ0du5SO2WpMEcjp8+mg3CQ@mail.gmail.com>
2015-08-10 11:16 ` Tony Camuso
2015-08-10 12:35 ` [PATCH 2/3 v3] Add default case to switches on enum variables Tony Camuso
2015-07-30 0:26 ` [PATCH 3/3] Add NOWARN and NOERR compile conditions Tony Camuso
2015-07-30 2:55 ` Josh Triplett
2015-07-30 11:45 ` Tony Camuso
2015-07-31 23:46 ` Christopher Li
2015-08-01 11:09 ` Tony Camuso
2015-08-01 17:52 ` Josh Triplett
2015-08-01 18:45 ` Christopher Li
2015-08-02 13:42 ` Tony Camuso
2015-08-02 23:16 ` Tony Camuso
2015-08-02 23:22 ` Tony Camuso
2015-08-03 11:23 ` Nicolai Stange
2015-08-03 11:47 ` Tony Camuso
2015-07-31 17:07 ` Tony Camuso
2015-07-31 17:12 ` [PATCH 3/3 V2] lib.c: add Wall_off switch Tony Camuso
2015-07-31 18:01 ` Tony Camuso
2015-07-31 19:27 ` [PATCH 3/3 V3] Add Wall_off switch to disable errors and warnings Tony Camuso
2015-08-01 12:59 ` Sam Ravnborg [this message]
2015-08-01 13:52 ` Tony Camuso
2015-08-03 16:35 ` [PATCH 3/3 v4] " Tony Camuso
2016-01-05 1:19 ` Luc Van Oostenryck
2016-01-13 14:39 ` Tony Camuso
2015-08-03 18:10 ` [PATCH 0/3] Minor enhancements and fixes Tony Camuso
2015-12-02 18:52 ` Tony Camuso
2016-02-02 18:54 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801125938.GA23735@ravnborg.org \
--to=sam@ravnborg.org \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=tcamuso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).