linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* rhashtable sparse annotations?
@ 2015-09-09 14:14 Andreas Gruenbacher
  2015-09-09 21:13 ` Thomas Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Gruenbacher @ 2015-09-09 14:14 UTC (permalink / raw)
  To: Nick Piggin, Thomas Graf, Christopher Li; +Cc: linux-sparse

Hi,

I'm seeing the following sparse errors which are seemingly related to
the hlist_bl_for_each_entry_rcu() macro:

$ make C=1 fs/dcache.o
[...]
include/linux/rculist_bl.h:23:33: error: incompatible types in
comparison expression (different address spaces)
fs/dcache.c:2183:9: error: incompatible types in comparison expression
(different address spaces)
include/linux/rculist_bl.h:23:33: error: incompatible types in
comparison expression (different address spaces)
fs/dcache.c:2303:9: error: incompatible types in comparison expression
(different address spaces)

I'm hitting the same kinds of errors in the gfs2 rhashtable code as
well, but it doesn't seem to happen in the network code. Does this
need fixing in rhashtable?

Thanks,
Andreas

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: rhashtable sparse annotations?
  2015-09-09 14:14 rhashtable sparse annotations? Andreas Gruenbacher
@ 2015-09-09 21:13 ` Thomas Graf
  2015-09-09 23:32   ` Andreas Gruenbacher
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Graf @ 2015-09-09 21:13 UTC (permalink / raw)
  To: Andreas Gruenbacher; +Cc: Nick Piggin, Christopher Li, linux-sparse

On 09/09/15 at 04:14pm, Andreas Gruenbacher wrote:
> Hi,
> 
> I'm seeing the following sparse errors which are seemingly related to
> the hlist_bl_for_each_entry_rcu() macro:
> 
> $ make C=1 fs/dcache.o
> [...]
> include/linux/rculist_bl.h:23:33: error: incompatible types in
> comparison expression (different address spaces)
> fs/dcache.c:2183:9: error: incompatible types in comparison expression
> (different address spaces)
> include/linux/rculist_bl.h:23:33: error: incompatible types in
> comparison expression (different address spaces)
> fs/dcache.c:2303:9: error: incompatible types in comparison expression
> (different address spaces)
> 
> I'm hitting the same kinds of errors in the gfs2 rhashtable code as
> well, but it doesn't seem to happen in the network code. Does this
> need fixing in rhashtable?

What's the rhashtable related sparse error for gfs2?

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: rhashtable sparse annotations?
  2015-09-09 21:13 ` Thomas Graf
@ 2015-09-09 23:32   ` Andreas Gruenbacher
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Gruenbacher @ 2015-09-09 23:32 UTC (permalink / raw)
  To: Thomas Graf; +Cc: Christopher Li, linux-sparse

2015-09-09 23:13 GMT+02:00 Thomas Graf <tgraf@suug.ch>:
> On 09/09/15 at 04:14pm, Andreas Gruenbacher wrote:
>> I'm hitting the same kinds of errors in the gfs2 rhashtable code as
>> well, but it doesn't seem to happen in the network code. Does this
>> need fixing in rhashtable?
>
> What's the rhashtable related sparse error for gfs2?

Mmh, it seems I was mixing things up: I do get the same kind of error
as in dcache.c, but the code is not rhashtable related, it's also a
hlist_bl_for_each_entry_rcu() loop. Sorry for the rhashtable noise,
Thomas.

Does anybody know how to fix the dcache.c sparse errors?

Thanks,
Andreas

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-09 23:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 14:14 rhashtable sparse annotations? Andreas Gruenbacher
2015-09-09 21:13 ` Thomas Graf
2015-09-09 23:32   ` Andreas Gruenbacher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).