linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christopher Li <sparse@chrisli.org>,
	Josh Triplett <josh@joshtriplett.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Brian Norris <computersforpeace@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC v2 0/3] sparse: Introduce __private to privatize members of structs
Date: Mon, 4 Jan 2016 14:21:53 -0800	[thread overview]
Message-ID: <20160104222153.GH32217@linux.vnet.ibm.com> (raw)
In-Reply-To: <1451362728-18961-1-git-send-email-boqun.feng@gmail.com>

On Tue, Dec 29, 2015 at 12:18:45PM +0800, Boqun Feng wrote:
> Hi all,
> 
> This is v2 of __private.
> 
> Link for v1: http://marc.info/?l=linux-sparse&m=144988906932520&w=2
> 
> Change since v1:
> 
> *	#undef __irqd_to_state after used (Peter Zijlstra)
> 
> 
> This patchset introduces a __private modifier for sparse to detect misuses of
> private members of structs. This could make maintenace a little easier and
> prevent some potential bugs.
> 
> 
> This patchset consists of three patches:
> 
> 1.	Introduce __private and related macro, also improve compiler.h a litte
> 	bit
> 
> 2.	Privatize rcu_node::lock
> 
> 3.	Privatize irq_common_data::state_use_accessors
> 
> This patchset is against
> 
> 	-rcu/rcu/next	c95a158356397844a5a6deb0bd58758084f891df
> 
> because it depends on commits:
> 	
> 	"rcu: Create transitive rnp->lock acquisition functions"
> and
> 	"rcu: Add transitivity to remaining rcu_node ->lock acquisitions
> 
> 
> Tested by 0day.
> 
> Looking forward to any suggestion, question and comment ;-)

Queued for review and testing, along with Thomas's Reviewed-by.  If all
goes well, I expect to send them upstream in the 4.6 merge window.

							Thanx, Paul


      parent reply	other threads:[~2016-01-04 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29  4:18 [RFC v2 0/3] sparse: Introduce __private to privatize members of structs Boqun Feng
2015-12-29  4:18 ` [RFC v2 1/3] sparse: Add " Boqun Feng
2015-12-29  4:18 ` [RFC v2 2/3] RCU: Privatize rcu_node::lock Boqun Feng
2015-12-29  4:18 ` [RFC v2 3/3] irq: Privatize irq_common_data::state_use_accessors Boqun Feng
2015-12-29  9:46   ` Thomas Gleixner
2016-01-04 22:21 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104222153.GH32217@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=apw@canonical.com \
    --cc=boqun.feng@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joe@perches.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=sparse@chrisli.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).