From: Lance Richardson <lrichard@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christopher Li <sparse@chrisli.org>,
Josh Triplett <josh@kernel.org>,
linux-sparse@vger.kernel.org
Subject: Re: dissect: teach do_expression() to handle EXPR_OFFSETOF
Date: Mon, 26 Sep 2016 13:52:15 -0400 [thread overview]
Message-ID: <20160926175213.GA31182@thinkcentre> (raw)
In-Reply-To: <20160208132657.GA19007@redhat.com>
+++ Oleg Nesterov [08/02/16 14:26 +0100]:
>Starting from a194f3e0 "implement __builtin_offsetof()" sparse handles
>offsetof() internally but dissect.c wasn't updated.
>
>Test case:
>
> struct S { int m; };
>
> void func(void)
> {
> __builtin_offsetof(struct S, m);
> }
>
>before this patch:
>
> 3:6 g def func void ( ... )
> T.c:5:38: warning: bad expr->type: 30
>
>after:
>
> 3:6 g def func void ( ... )
> 1:8 s def S
> 5:38 s --- S.m int
>
>While at it, update my email.
>
>Signed-off-by: Oleg Nesterov <oleg@redhat.com>
LGTM, builds and test case works as expected.
Acked-by: Lance Richardson <lrichard@redhat.com>
next prev parent reply other threads:[~2016-09-26 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 13:26 [PATCH] dissect: teach do_expression() to handle EXPR_OFFSETOF Oleg Nesterov
2016-09-26 17:52 ` Lance Richardson [this message]
2016-11-02 14:21 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926175213.GA31182@thinkcentre \
--to=lrichard@redhat.com \
--cc=josh@kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).