From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Emily Maier <emily@emilymaier.net>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/2] validation: Check C99 for loop variables
Date: Wed, 2 Nov 2016 15:04:20 +0100 [thread overview]
Message-ID: <20161102140419.GB9029@macpro.local> (raw)
In-Reply-To: <1462365584-20536-2-git-send-email-emily@emilymaier.net>
On Wed, May 04, 2016 at 08:39:44AM -0400, Emily Maier wrote:
> Previously, sparse would generate incorrect code in the presence of a
> C99 variable declaration inside the for statement, completely dropping
> the code after the end of the for loop. Check that it's now behaving
> correctly by entering a context and not leaving it at the end of the
> loop.
>
> Signed-off-by: Emily Maier <emily@emilymaier.net>
> ---
I think a simpler test case showing the generality of the problem
would be even nicer but that would involve the output of
test-linearize and as such this is not usable in the test suite.
This test case has the decisive advantage to be testable.
Revieved-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
next prev parent reply other threads:[~2016-11-02 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 12:39 [PATCH 1/2] linearize: Emit C99 declarations correctly Emily Maier
2016-05-04 12:39 ` [PATCH 2/2] validation: Check C99 for loop variables Emily Maier
2016-11-02 14:04 ` Luc Van Oostenryck [this message]
2016-11-02 13:57 ` [PATCH 1/2] linearize: Emit C99 declarations correctly Luc Van Oostenryck
2016-11-17 9:14 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102140419.GB9029@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=emily@emilymaier.net \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).