From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: [PATCH 4/5] testsuite: simplify the ioc-typecheck case
Date: Wed, 2 Nov 2016 22:45:08 +0100 [thread overview]
Message-ID: <20161102214509.36571-5-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161102214509.36571-1-luc.vanoostenryck@gmail.com>
The test was relatively convoluted and it wasn't very clear what
was the problem and waht was tested.
The real problem is simply a problem about a non-constant
expression in an array designator.
Simplify the test to clearly show that.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
CC: Hans Verkuil <hans.verkuil@cisco.com>
---
validation/ioc-typecheck.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/validation/ioc-typecheck.c b/validation/ioc-typecheck.c
index aa060f7b..34b37d31 100644
--- a/validation/ioc-typecheck.c
+++ b/validation/ioc-typecheck.c
@@ -1,16 +1,10 @@
extern unsigned int __invalid_size_argument_for_IOC;
-#define _IOC_TYPECHECK(t) \
- ((sizeof(t) == sizeof(t[1]) && \
- sizeof(t) < (1 << 14)) ? \
- sizeof(t) : __invalid_size_argument_for_IOC)
-
-#define TEST_IOCTL (50 | (_IOC_TYPECHECK(unsigned) << 8))
next prev parent reply other threads:[~2016-11-02 21:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 21:45 [PATCH 0/5] tests & testsuite small improvements Luc Van Oostenryck
2016-11-02 21:45 ` [PATCH 1/5] testsuite: give a proper name to the 'binary-constant' test Luc Van Oostenryck
2016-11-17 10:19 ` Christopher Li
2016-11-02 21:45 ` [PATCH 2/5] testsuite: make tests known to fail effectively fail Luc Van Oostenryck
2016-11-17 14:16 ` Christopher Li
2016-11-02 21:45 ` [PATCH 3/5] testsuite: report as error tests known to fail but which succeed Luc Van Oostenryck
2016-11-17 16:13 ` Christopher Li
2016-11-18 12:52 ` Luc Van Oostenryck
2016-11-19 0:44 ` Luc Van Oostenryck
2016-11-20 1:43 ` Christopher Li
2016-11-02 21:45 ` Luc Van Oostenryck [this message]
2016-11-17 16:17 ` [PATCH 4/5] testsuite: simplify the ioc-typecheck case Christopher Li
2016-11-02 21:45 ` [PATCH 5/5] testsuite: add a simple test for -Wenum-mismatch Luc Van Oostenryck
2016-11-17 16:25 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102214509.36571-5-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).