From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 2/8] fix killing OP_SETVAL instructions
Date: Thu, 17 Nov 2016 15:35:01 +0100 [thread overview]
Message-ID: <20161117143507.3598-3-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161117143507.3598-1-luc.vanoostenryck@gmail.com>
Currently, kill_instruction() ignore OP_SETVAL instructions
with the result that some instructions are not optimized away
as expected.
For example, when looking at the output of test-linearize,
the following function:
static int kill_setval(void)
{
l:
return &&l && 0;
}
gives the following output:
kill_setval:
set.64 %r6 <- .L1
ret.32 $0
The 'set' instruction is obviously unneeded but nevertheless present.
With the patch, the output is the expected:
kill_set:
ret.32 $0
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
simplify.c | 1 +
validation/kill-replaced-insn.c | 7 +++++++
2 files changed, 8 insertions(+)
diff --git a/simplify.c b/simplify.c
index 85da5bec..d07ca1b1 100644
--- a/simplify.c
+++ b/simplify.c
@@ -195,6 +195,7 @@ void kill_instruction(struct instruction *insn)
repeat_phase |= REPEAT_CSE;
return;
+ case OP_SETVAL:
case OP_NOT: case OP_NEG:
insn->bb = NULL;
kill_use(&insn->src1);
diff --git a/validation/kill-replaced-insn.c b/validation/kill-replaced-insn.c
index be031b6c..92021877 100644
--- a/validation/kill-replaced-insn.c
+++ b/validation/kill-replaced-insn.c
@@ -30,6 +30,12 @@ static int kill_select(int a)
return (a ? 1 : 0) && 0;
}
+static int kill_setval(int a)
+{
+l:
+ return &&l && 0;
+}
+
static int kill_load(int *a)
{
return *a && 0;
@@ -51,4 +57,5 @@ static int kill_store(int *a)
* check-output-excludes: ptrcast\\.
* check-output-excludes: fpcast\\.
* check-output-excludes: sel\\.
+ * check-output-excludes: set\\.
*/
--
2.10.2
next prev parent reply other threads:[~2016-11-17 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 14:34 [PATCH 0/8] fix uses of killed instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 1/8] kill uses of replaced instructions Luc Van Oostenryck
2016-11-17 14:35 ` Luc Van Oostenryck [this message]
2016-11-17 14:35 ` [PATCH 3/8] fix killing OP_PHI instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 4/8] fix killing OP_CAST & friends Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 5/8] fix killing OP_SELECT Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 6/8] fix killing OP_COMPUTEDGOTO Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 7/8] explicitely ignore killing OP_ENTRY Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 8/8] cleanup kill_instruction() Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117143507.3598-3-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).