From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 6/8] fix killing OP_COMPUTEDGOTO
Date: Thu, 17 Nov 2016 15:35:05 +0100 [thread overview]
Message-ID: <20161117143507.3598-7-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161117143507.3598-1-luc.vanoostenryck@gmail.com>
Currently kill_instruction() doesn't do anything with the
operands of computed gotos (OP_COMPUTEDGOTO). But when these
instructions are removed we must also remove the operands 'usage'.
Without this some instructions, which provides the select's
operands, are not optimized away as expected.
The fix consists by killing it's operand much like what is done for
conditional branches.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
simplify.c | 1 +
validation/kill-computedgoto.c | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 validation/kill-computedgoto.c
diff --git a/simplify.c b/simplify.c
index 1dd1bda6..1be9b3d0 100644
--- a/simplify.c
+++ b/simplify.c
@@ -226,6 +226,7 @@ void kill_instruction(struct instruction *insn)
kill_use(&insn->src3);
return;
case OP_BR:
+ case OP_COMPUTEDGOTO:
insn->bb = NULL;
repeat_phase |= REPEAT_CSE;
if (insn->cond)
diff --git a/validation/kill-computedgoto.c b/validation/kill-computedgoto.c
new file mode 100644
index 00000000..3b3ed8ff
--- /dev/null
+++ b/validation/kill-computedgoto.c
@@ -0,0 +1,17 @@
+void foo(int a);
+void foo(int a)
+{
+ void *l = &&end + 3;
+
+end:
+ if (a * 0)
+ goto *l;
+}
+
+/*
+ * check-name: kill-computedgoto
+ * check-command: test-linearize $file
+ *
+ * check-output-ignore
+ * check-output-excludes: add\\.
+ */
--
2.10.2
next prev parent reply other threads:[~2016-11-17 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 14:34 [PATCH 0/8] fix uses of killed instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 1/8] kill uses of replaced instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 2/8] fix killing OP_SETVAL instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 3/8] fix killing OP_PHI instructions Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 4/8] fix killing OP_CAST & friends Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 5/8] fix killing OP_SELECT Luc Van Oostenryck
2016-11-17 14:35 ` Luc Van Oostenryck [this message]
2016-11-17 14:35 ` [PATCH 7/8] explicitely ignore killing OP_ENTRY Luc Van Oostenryck
2016-11-17 14:35 ` [PATCH 8/8] cleanup kill_instruction() Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117143507.3598-7-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).