From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Linux-Sparse <linux-sparse@vger.kernel.org>,
Nicolai Stange <nicstange@gmail.com>
Subject: Re: [PATCH v2] implement constant-folding in __builtin_bswap*()
Date: Tue, 22 Nov 2016 14:15:44 +0100 [thread overview]
Message-ID: <20161122131543.GA8370@macbook.local> (raw)
In-Reply-To: <CANeU7QmSSPT9cq1fNqUxqk5DNWDn7RNLjKnFVdKUdJtCrqfBLg@mail.gmail.com>
On Tue, Nov 22, 2016 at 07:13:11PM +0800, Christopher Li wrote:
>
> Otherwise, expand_bswap should proceed to calculate the return
> value of the bswap call and rewrite the call expression into a constant.
> Some what similar to the "__builtin_constant_p".
>
> I will see if I can hack up some thing very quick.
>
> Chris
> --
I think it would be best to do any change related tos handling
of constant expressions on to of Nicolai Stange's serie:
http://marc.info/?l=linux-sparse&m=145429372932235
Not only this serie fixes several issues but it handle the
expression constantnes in a much more systematic way.
Also, I wouldn't like that changes in this area make it
more difficult to integrate this serie (which is already waiting
since July or August 2015).
Luc
next prev parent reply other threads:[~2016-11-22 13:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 9:55 [PATCH v2] implement constant-folding in __builtin_bswap*() Johannes Berg
2016-11-21 2:38 ` Christopher Li
2016-11-21 9:45 ` Johannes Berg
2016-11-22 11:13 ` Christopher Li
2016-11-22 11:39 ` Christopher Li
2016-11-22 13:15 ` Luc Van Oostenryck [this message]
2016-11-22 16:32 ` Christopher Li
2016-11-22 17:12 ` Luc Van Oostenryck
2016-11-23 1:23 ` Christopher Li
2016-11-22 20:16 ` Luc Van Oostenryck
2016-11-23 1:25 ` Christopher Li
2016-11-23 20:38 ` [PATCH] add test case for builtin bswap with constant args Luc Van Oostenryck
2016-11-24 0:17 ` Christopher Li
2016-11-24 5:30 ` Christopher Li
2016-11-24 13:00 ` Luc Van Oostenryck
2016-11-23 20:48 ` [PATCH v2] implement constant-folding in __builtin_bswap*() Luc Van Oostenryck
2016-11-24 0:56 ` Christopher Li
2016-11-24 0:58 ` Christopher Li
2016-11-24 1:36 ` Luc Van Oostenryck
2016-11-24 3:17 ` Christopher Li
2016-11-24 1:31 ` Luc Van Oostenryck
2016-11-24 3:23 ` Christopher Li
2016-11-23 6:28 ` Johannes Berg
2016-11-23 14:30 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122131543.GA8370@macbook.local \
--to=luc.vanoostenryck@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-sparse@vger.kernel.org \
--cc=nicstange@gmail.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).