From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 0/2] normalize bb's label names for testing
Date: Tue, 22 Nov 2016 18:02:31 +0100 [thread overview]
Message-ID: <20161122170230.GA8847@macbook.local> (raw)
In-Reply-To: <CANeU7Qk+_N7A+DMKrLxoNi1fq8twfpJ8jLeartsc+jsMQiXN0Q@mail.gmail.com>
On Wed, Nov 23, 2016 at 12:44:36AM +0800, Christopher Li wrote:
>
> It is private to the back end. If you consider test-linearize as one of
> the back end, it compile the C code into readable text form. it is fine
> to use it. I assume the label ID is only make sense for test-linearize,
> not for other back end?
I use it for test-linearize, test-unssa and others stuff I'll coming up
with in the coming weeks I hope. So nothing I consider as 'private',
external or out-of-tree.
> I am also OK with just introduce one more field ID for basic blocks.
> There are far less basic blocks than instructions. So even size of basic
> block bump up by a integer is not a big deal.
Yes, I think so too.
But anyway, I already sent a patch which reuse the 'priv' member with
an union. It will always be very easy to remove the union later if needed.
> > Sure.
> > But it should be noted that this filtering stuff *could* be useful for other
> > things to (but I have no such uses).
>
> We can always deal with it when such usage actually come up.
Absolutely.
Luc
next prev parent reply other threads:[~2016-11-22 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 4:14 [PATCH 0/2] normalize bb's label names for testing Luc Van Oostenryck
2016-11-21 4:14 ` [PATCH 1/2] testsuite: allow commands to use pipes Luc Van Oostenryck
2016-11-21 4:14 ` [PATCH 2/2] testsuite: add a script to normalize label names Luc Van Oostenryck
2016-11-22 10:02 ` [PATCH 0/2] normalize bb's label names for testing Christopher Li
2016-11-22 13:27 ` Luc Van Oostenryck
2016-11-22 16:44 ` Christopher Li
2016-11-22 17:02 ` Luc Van Oostenryck [this message]
2016-11-22 15:42 ` [PATCH] give comparable label's names to basic blocks Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122170230.GA8847@macbook.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).