From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH] recursive phi_defines cannot happen
Date: Thu, 8 Dec 2016 04:34:38 +0100 [thread overview]
Message-ID: <20161208033438.7607-1-luc.vanoostenryck@gmail.com> (raw)
The function phi_defines() does the liveness tracking of phi-pseudos
(pseudos in OP_PHIs args). While doing this, the function is
recursively called when the pseudo would be defined by another phi-node;
but this condition is impossible because all phi-pseudos are defined
by OP_PHISOURCE instructions.
This patch remove the recursive call and its associated test.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
liveness.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/liveness.c b/liveness.c
index eeff0f79..fb696720 100644
--- a/liveness.c
+++ b/liveness.c
@@ -23,10 +23,6 @@ static void phi_defines(struct instruction * phi_node, pseudo_t target,
def = phi->def;
if (!def || !def->bb)
continue;
- if (def->opcode == OP_PHI) {
- phi_defines(def, target, defines);
- continue;
- }
defines(def->bb, phi->def, target);
} END_FOR_EACH_PTR(phi);
}
--
2.10.2
reply other threads:[~2016-12-08 3:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208033438.7607-1-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).