From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v2 1/5] unssa: do not try to update liveness
Date: Mon, 12 Dec 2016 16:28:57 +0100 [thread overview]
Message-ID: <20161212152901.24948-2-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161212152901.24948-1-luc.vanoostenryck@gmail.com>
The unSSA step used to try to maintain the liveness info
while creating the copies but this can't be done so simply
(what is updated is only the liveness for the current bb
while it needs to be done for all concerned bbs).
If/when liveness is needed after this step, it need to be
redone by calling track_pseudo_liveness().
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
unssa.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/unssa.c b/unssa.c
index 382095d7..85b1388d 100644
--- a/unssa.c
+++ b/unssa.c
@@ -49,9 +49,6 @@ static void replace_phi_node(struct instruction *phi)
tmp->ident = phi->target->ident;
tmp->def = NULL; // defined by all the phisrc
- // update the current liveness
- remove_pseudo(&phi->bb->needs, phi->target);
- add_pseudo(&phi->bb->needs, tmp);
track_phi_uses(phi);
phi->opcode = OP_COPY;
--
2.10.2
next prev parent reply other threads:[~2016-12-12 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 15:28 [PATCH v2 0/5] unssa improvements Luc Van Oostenryck
2016-12-12 15:28 ` Luc Van Oostenryck [this message]
2016-12-12 15:28 ` [PATCH v2 2/5] unssa: simplify rewrite of OP_PHISOURCE Luc Van Oostenryck
2016-12-12 15:28 ` [PATCH v2 3/5] unssa: try to avoid some OP_PHI copies Luc Van Oostenryck
2016-12-12 15:29 ` [PATCH v2 4/5] unssa: eliminate trivial phisrc copies Luc Van Oostenryck
2016-12-12 15:29 ` [PATCH v2 5/5] unssa: update comment about the unneeded copies Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212152901.24948-2-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).