From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v2 4/5] unssa: eliminate trivial phisrc copies
Date: Mon, 12 Dec 2016 16:29:00 +0100 [thread overview]
Message-ID: <20161212152901.24948-5-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20161212152901.24948-1-luc.vanoostenryck@gmail.com>
A OP_PHISOURCE which is the only user of its operand
can be trivially eliminated. For example, in:
add %r6, ...
...
phisrc %rt, %r6
the phisrc can safely be eliminated if no other instruction use %r6.
With this patch it's rewritten as:
add %rt, ...
...
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
unssa.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/unssa.c b/unssa.c
index 50782352..a7085ca0 100644
--- a/unssa.c
+++ b/unssa.c
@@ -30,6 +30,11 @@
#include <assert.h>
+static inline int nbr_pseudo_users(pseudo_t p)
+{
+ return ptr_list_size((struct ptr_list *)p->users);
+}
+
static int simplify_phi_node(struct instruction *phi, pseudo_t tmp)
{
pseudo_t target = phi->target;
@@ -72,6 +77,7 @@ static void replace_phi_node(struct instruction *phi)
// rewrite all it's phi_src to copy to a new tmp
FOR_EACH_PTR(phi->phi_list, p) {
struct instruction *def = p->def;
+ pseudo_t src;
if (p == VOID)
continue;
@@ -80,6 +86,22 @@ static void replace_phi_node(struct instruction *phi)
def->opcode = OP_COPY;
def->target = tmp;
+
+ // can we eliminate the copy?
+ src = def->phi_src;
+ if (src->type != PSEUDO_REG)
+ continue;
+ switch (nbr_pseudo_users(src)) {
+ struct instruction *insn;
+ case 1:
+ insn = src->def;
+ if (!insn)
+ break;
+ insn->target = tmp;
+ case 0:
+ kill_instruction(def);
+ def->bb = NULL;
+ }
} END_FOR_EACH_PTR(p);
if (!phi->bb)
--
2.10.2
next prev parent reply other threads:[~2016-12-12 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 15:28 [PATCH v2 0/5] unssa improvements Luc Van Oostenryck
2016-12-12 15:28 ` [PATCH v2 1/5] unssa: do not try to update liveness Luc Van Oostenryck
2016-12-12 15:28 ` [PATCH v2 2/5] unssa: simplify rewrite of OP_PHISOURCE Luc Van Oostenryck
2016-12-12 15:28 ` [PATCH v2 3/5] unssa: try to avoid some OP_PHI copies Luc Van Oostenryck
2016-12-12 15:29 ` Luc Van Oostenryck [this message]
2016-12-12 15:29 ` [PATCH v2 5/5] unssa: update comment about the unneeded copies Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212152901.24948-5-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).