From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: [PATCH v2 8/8] cleanup kill_instruction() Date: Sun, 29 Jan 2017 11:48:08 +0100 Message-ID: <20170129104808.2500-9-luc.vanoostenryck@gmail.com> References: <20170129104808.2500-1-luc.vanoostenryck@gmail.com> Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35538 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdA2Ks4 (ORCPT ); Sun, 29 Jan 2017 05:48:56 -0500 Received: by mail-wm0-f67.google.com with SMTP id u63so1548937wmu.2 for ; Sun, 29 Jan 2017 02:48:55 -0800 (PST) In-Reply-To: <20170129104808.2500-1-luc.vanoostenryck@gmail.com> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: linux-sparse@vger.kernel.org Cc: Christopher Li , Luc Van Oostenryck No functional changes: - factorize out the '->bb = NULL' and '|= REPEAT_CSE'. - fall through the switch cases for ternary/bunary/unary ops. Signed-off-by: Luc Van Oostenryck --- simplify.c | 47 +++++++++++++++++++++-------------------------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/simplify.c b/simplify.c index 66550fa3d..f62fc83a1 100644 --- a/simplify.c +++ b/simplify.c @@ -188,54 +188,49 @@ void kill_instruction(struct instruction *insn) return; switch (insn->opcode) { + case OP_SEL: + case OP_RANGE: + kill_use(&insn->src3); + /* fall through */ + case OP_BINARY ... OP_BINCMP_END: - insn->bb = NULL; - kill_use(&insn->src1); kill_use(&insn->src2); - repeat_phase |= REPEAT_CSE; - return; + /* fall through */ case OP_CAST: case OP_SCAST: case OP_FPCAST: case OP_PTRCAST: case OP_NOT: case OP_NEG: - insn->bb = NULL; kill_use(&insn->src1); - repeat_phase |= REPEAT_CSE; - return; + break; case OP_PHI: clear_phi(insn); - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - return; + break; case OP_SYMADDR: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE | REPEAT_SYMBOL_CLEANUP; - return; + repeat_phase |= REPEAT_SYMBOL_CLEANUP; + break; - case OP_SEL: - case OP_RANGE: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - kill_use(&insn->src1); - kill_use(&insn->src2); - kill_use(&insn->src3); - return; case OP_BR: + if (!insn->bb_true || !insn->bb_false) + break; + /* fall through */ + case OP_COMPUTEDGOTO: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - if (insn->bb_true && insn->bb_false) - kill_use(&insn->cond); - return; + kill_use(&insn->cond); + break; case OP_ENTRY: + default: /* ignore */ return; } + + insn->bb = NULL; + repeat_phase |= REPEAT_CSE; + return; } /* -- 2.11.0