From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Chris Li <christ.li@gmail.com>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 2/3] allow builtins to have prototype and evaluate/expand methods
Date: Tue, 7 Feb 2017 21:12:54 +0100 [thread overview]
Message-ID: <20170207201253.4i2ye6inqwma65rf@macpro.local> (raw)
In-Reply-To: <CANeU7QkTLwcVq4Spv4CcZjpjuZybW1=39Z5hU=5Qu6jYGB8=EA@mail.gmail.com>
On Wed, Feb 08, 2017 at 03:49:54AM +0800, Chris Li wrote:
> On Tue, Jan 24, 2017 at 5:37 AM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > So far, builtin functions which had some evaluate/expand method
> > couldn't also have a prototype because each would have its own symbol
> > and only the one for the prototype will be seen.
> > This also meant that the evaluate/expand functions had to take care
> > to set the correct types for they argumenst & results, which is fine
> > for some generic builtins like __builtin_constant_p() it's much less
> > practical for the ones like __builtin_bswap{16,32,64}().
> >
> > Fix this by marking the idents for the builtins we declare some
> > evaluate/expand methods has being the ident of a builtin function
> > and later at evaluation time, to share the methods between all the symbols
> > corresponding to an identifier so marked.
>
> This certainly fix the problem for builtin functions. However, I think there
> is more general bug in sparse not limit to builtin functions. When the symbol
> is declare twice, the later one did not migrate all the declare information from
> the previous one.
I'm very well aware of this bug/problem, it creates all sort of complications
but I vaguely understood it was a design choice. To be 100%, you're talking
the fact that each declaration create a new symbol only related by their
identifier chain, right?
> In function external_declaration()
>
> check_declaration(decl);
> if (decl->same_symbol)
> decl->definition = decl->same_symbol->definition;
>
> Here it only migrates the definition. I think if you add symbol->op in
> the migration
> as well, it *should* work for your case. I haven't test this myself.
> If that works for you, it is a more general fix. Want to give it a try?
>
> We might want to extract the migration code into a new function and
> later adding new code it. e.g. function attributes.
Yes and diagnose any compatibility.
I'll give it a try but I won't be able to do that before the weekend.
Luc
next prev parent reply other threads:[~2017-02-07 20:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 21:37 [PATCH 0/3] builtins expansion Luc Van Oostenryck
2017-01-23 21:37 ` [PATCH 1/3] move evaluation & expansion of builtins in a separate file Luc Van Oostenryck
2017-01-23 21:37 ` [PATCH 2/3] allow builtins to have prototype and evaluate/expand methods Luc Van Oostenryck
2017-02-07 19:49 ` Chris Li
2017-02-07 20:12 ` Luc Van Oostenryck [this message]
2017-02-07 20:26 ` Chris Li
2017-02-07 20:32 ` Christopher Li
2017-02-07 21:34 ` Luc Van Oostenryck
2017-02-07 22:19 ` Christopher Li
2017-02-12 15:03 ` Luc Van Oostenryck
2017-02-12 15:10 ` [PATCH v2 0/3] builtins expansion Luc Van Oostenryck
2017-02-12 15:10 ` [PATCH v2 1/3] move evaluation & expansion of builtins in a separate file Luc Van Oostenryck
2017-02-12 15:10 ` [PATCH v2 2/3] let identical symbols share their evaluate/expand methods Luc Van Oostenryck
2017-02-12 15:11 ` [PATCH v2 3/3] expand __builtin_bswap*() with constant args Luc Van Oostenryck
2017-02-13 1:54 ` [PATCH v2 0/3] builtins expansion Christopher Li
2017-02-12 23:35 ` [PATCH 2/3] allow builtins to have prototype and evaluate/expand methods Chris Li
2017-01-23 21:37 ` [PATCH 3/3] expand __builtin_bswap*() with constant args Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207201253.4i2ye6inqwma65rf@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=christ.li@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).