* [PATCH] use VOID instead of directly using &void_pseudo
@ 2017-02-20 10:45 Luc Van Oostenryck
2017-02-27 15:40 ` Christopher Li
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2017-02-20 10:45 UTC (permalink / raw)
To: linux-sparse; +Cc: Christopher Li, Luc Van Oostenryck
---
linearize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linearize.c b/linearize.c
index 99203d915..6908e9f57 100644
--- a/linearize.c
+++ b/linearize.c
@@ -1862,7 +1862,7 @@ static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
struct basic_block *active;
pseudo_t src = linearize_expression(ep, expr);
active = ep->active;
- if (active && src != &void_pseudo) {
+ if (active && src != VOID) {
struct instruction *phi_node = first_instruction(bb_return->insns);
pseudo_t phi;
if (!phi_node) {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] use VOID instead of directly using &void_pseudo
2017-02-20 10:45 [PATCH] use VOID instead of directly using &void_pseudo Luc Van Oostenryck
@ 2017-02-27 15:40 ` Christopher Li
2017-02-27 21:23 ` Luc Van Oostenryck
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Li @ 2017-02-27 15:40 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: Linux-Sparse
On Mon, Feb 20, 2017 at 6:45 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
>
> diff --git a/linearize.c b/linearize.c
> index 99203d915..6908e9f57 100644
> --- a/linearize.c
> +++ b/linearize.c
> @@ -1862,7 +1862,7 @@ static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
> struct basic_block *active;
> pseudo_t src = linearize_expression(ep, expr);
> active = ep->active;
> - if (active && src != &void_pseudo) {
> + if (active && src != VOID) {
Looks good. Can you add S-O-B for this?
Thanks
Chris
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] use VOID instead of directly using &void_pseudo
2017-02-27 15:40 ` Christopher Li
@ 2017-02-27 21:23 ` Luc Van Oostenryck
0 siblings, 0 replies; 3+ messages in thread
From: Luc Van Oostenryck @ 2017-02-27 21:23 UTC (permalink / raw)
To: Christopher Li; +Cc: Linux-Sparse
On Mon, Feb 27, 2017 at 4:40 PM, Christopher Li <sparse@chrisli.org> wrote:
> On Mon, Feb 20, 2017 at 6:45 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
>>
>> diff --git a/linearize.c b/linearize.c
>> index 99203d915..6908e9f57 100644
>> --- a/linearize.c
>> +++ b/linearize.c
>> @@ -1862,7 +1862,7 @@ static pseudo_t linearize_return(struct entrypoint *ep, struct statement *stmt)
>> struct basic_block *active;
>> pseudo_t src = linearize_expression(ep, expr);
>> active = ep->active;
>> - if (active && src != &void_pseudo) {
>> + if (active && src != VOID) {
>
> Looks good. Can you add S-O-B for this?
>
> Thanks
Sure.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-27 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 10:45 [PATCH] use VOID instead of directly using &void_pseudo Luc Van Oostenryck
2017-02-27 15:40 ` Christopher Li
2017-02-27 21:23 ` Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).