* [PATCH 1/5] use option: '-Woverride-init'
2017-02-22 15:30 ` [PATCH 0/5] improve detection of overlapping initializers Luc Van Oostenryck
@ 2017-02-22 15:30 ` Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 2/5] add test case for warnings about overlapping initializers Luc Van Oostenryck
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-22 15:30 UTC (permalink / raw)
To: linux-sparse
Cc: Christopher Li, Mark Rutland, Stephen Boyd, Will Deacon,
Luc Van Oostenryck
Sparse warns unconditionally about overlapping initilalizers.
Introduces a warning flag to control this, use the same name
as GCC's and enabled it by default.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 3 +++
lib.c | 2 ++
lib.h | 1 +
validation/Woverride-init-def.c | 14 ++++++++++++++
validation/Woverride-init-no.c | 12 ++++++++++++
validation/Woverride-init-yes.c | 14 ++++++++++++++
6 files changed, 46 insertions(+)
create mode 100644 validation/Woverride-init-def.c
create mode 100644 validation/Woverride-init-no.c
create mode 100644 validation/Woverride-init-yes.c
diff --git a/expand.c b/expand.c
index 7af12707e..7457c94dd 100644
--- a/expand.c
+++ b/expand.c
@@ -916,6 +916,9 @@ static void verify_nonoverlapping(struct expression_list **list)
struct expression *a = NULL;
struct expression *b;
+ if (!Woverride_init)
+ return;
+
FOR_EACH_PTR(*list, b) {
if (!b->ctype || !b->ctype->bit_size)
continue;
diff --git a/lib.c b/lib.c
index d47325243..a20f68aa2 100644
--- a/lib.c
+++ b/lib.c
@@ -231,6 +231,7 @@ int Wsparse_error = 0;
int Wnon_pointer_null = 1;
int Wold_initializer = 1;
int Wone_bit_signed_bitfield = 1;
+int Woverride_init = 1;
int Wparen_string = 0;
int Wptr_subtraction_blows = 0;
int Wreturn_void = 0;
@@ -480,6 +481,7 @@ static const struct warning {
{ "non-pointer-null", &Wnon_pointer_null },
{ "old-initializer", &Wold_initializer },
{ "one-bit-signed-bitfield", &Wone_bit_signed_bitfield },
+ { "override-init", &Woverride_init },
{ "paren-string", &Wparen_string },
{ "ptr-subtraction-blows", &Wptr_subtraction_blows },
{ "return-void", &Wreturn_void },
diff --git a/lib.h b/lib.h
index 095b1f517..35edd3217 100644
--- a/lib.h
+++ b/lib.h
@@ -117,6 +117,7 @@ extern int Winit_cstring;
extern int Wnon_pointer_null;
extern int Wold_initializer;
extern int Wone_bit_signed_bitfield;
+extern int Woverride_init;
extern int Wparen_string;
extern int Wptr_subtraction_blows;
extern int Wreturn_void;
diff --git a/validation/Woverride-init-def.c b/validation/Woverride-init-def.c
new file mode 100644
index 000000000..95ecf33be
--- /dev/null
+++ b/validation/Woverride-init-def.c
@@ -0,0 +1,14 @@
+static int array[] = {
+ [1] = 3,
+ [1] = 1, /* check-should-warn */
+};
+
+/*
+ * check-name: Woverride-init-def
+ * check-command: sparse $file
+ *
+ * check-error-start
+Woverride-init-def.c:2:10: warning: Initializer entry defined twice
+Woverride-init-def.c:3:10: also defined here
+ * check-error-end
+ */
diff --git a/validation/Woverride-init-no.c b/validation/Woverride-init-no.c
new file mode 100644
index 000000000..ba4d82b9f
--- /dev/null
+++ b/validation/Woverride-init-no.c
@@ -0,0 +1,12 @@
+static int array[] = {
+ [1] = 3,
+ [1] = 1, /* check-should-warn */
+};
+
+/*
+ * check-name: Woverride-init-no
+ * check-command: sparse -Wno-override-init $file
+ *
+ * check-error-start
+ * check-error-end
+ */
diff --git a/validation/Woverride-init-yes.c b/validation/Woverride-init-yes.c
new file mode 100644
index 000000000..c04a836be
--- /dev/null
+++ b/validation/Woverride-init-yes.c
@@ -0,0 +1,14 @@
+static int array[] = {
+ [1] = 3,
+ [1] = 1, /* check-should-warn */
+};
+
+/*
+ * check-name: Woverride-init-yes
+ * check-command: sparse -Woverride-init $file
+ *
+ * check-error-start
+Woverride-init-yes.c:2:10: warning: Initializer entry defined twice
+Woverride-init-yes.c:3:10: also defined here
+ * check-error-end
+ */
--
2.11.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/5] add test case for warnings about overlapping initializers
2017-02-22 15:30 ` [PATCH 0/5] improve detection of overlapping initializers Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 1/5] use option: '-Woverride-init' Luc Van Oostenryck
@ 2017-02-22 15:30 ` Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 3/5] allow to warn on all " Luc Van Oostenryck
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-22 15:30 UTC (permalink / raw)
To: linux-sparse
Cc: Christopher Li, Mark Rutland, Stephen Boyd, Will Deacon,
Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/field-override.c | 88 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 88 insertions(+)
create mode 100644 validation/field-override.c
diff --git a/validation/field-override.c b/validation/field-override.c
new file mode 100644
index 000000000..d5d00dfa8
--- /dev/null
+++ b/validation/field-override.c
@@ -0,0 +1,88 @@
+static int ref[] = {
+ [1] = 3,
+ [2] = 3,
+ [3] = 3,
+ [2] = 2, /* check-should-warn */
+ [1] = 1, /* check-should-warn */
+};
+
+static int foo[] = {
+ [1 ... 3] = 3,
+};
+
+static int foz[4] = {
+ [0 ... 3] = 3,
+ [0] = 0,
+ [1] = 0,
+ [2 ... 3] = 1,
+ [2] = 3, /* check-should-warn */
+ [3] = 3, /* check-should-warn */
+};
+
+static int bar[] = {
+ [1 ... 3] = 3,
+ [1] = 1, /* check-should-warn */
+ [2] = 2, /* check-should-warn */
+ [2 ... 4] = 2, /* check-should-warn */
+ [2 ... 3] = 2, /* check-should-warn */
+ [4] = 4, /* check-should-warn */
+ [0] = 0,
+ [5] = 5,
+};
+
+static int baz[3][3] = {
+ [0 ... 2][0 ... 2] = 0,
+ [0] = { 0, 0, 0, }, /* check-should-warn */
+ [0][0] = 1, /* check-should-warn */
+ [1] = { 0, 0, 0, }, /* check-should-warn */
+ [1][0] = 1, /* check-should-warn */
+ [1][1] = 1, /* check-should-warn */
+ [1 ... 2][1 ... 2] = 2,
+};
+
+
+struct s {
+ int i;
+ int a[2];
+};
+
+static struct s s = {
+ .a[0] = 0,
+ .a[1] = 1,
+};
+
+static struct s a[2] = {
+ [0].i = 0,
+ [1].i = 1,
+ [0].a[0] = 2,
+ [0].a[1] = 3,
+};
+
+static struct s b[2] = {
+ [0 ... 1] = { 0, { 1, 2 }, },
+ [0].i = 0,
+ [1].i = 1,
+ [0].a[0] = 2,
+ [0].a[1] = 3,
+};
+
+/*
+ * check-name: field-override
+ * check-command: sparse -Woverride-init $file
+ * check-known-to-fail
+ *
+ * check-error-start
+field-override.c:2:10: warning: Initializer entry defined twice
+field-override.c:6:10: also defined here
+field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:15:10: also defined here
+field-override.c:23:10: warning: Initializer entry defined twice
+field-override.c:24:10: also defined here
+field-override.c:23:10: warning: Initializer entry defined twice
+field-override.c:25:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:35:10: also defined here
+field-override.c:62:10: warning: Initializer entry defined twice
+field-override.c:63:10: also defined here
+ * check-error-end
+ */
--
2.11.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] allow to warn on all overlapping initializers
2017-02-22 15:30 ` [PATCH 0/5] improve detection of overlapping initializers Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 1/5] use option: '-Woverride-init' Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 2/5] add test case for warnings about overlapping initializers Luc Van Oostenryck
@ 2017-02-22 15:30 ` Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 4/5] fix checking of overlapping initializer Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 5/5] ignore whole-range " Luc Van Oostenryck
4 siblings, 0 replies; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-22 15:30 UTC (permalink / raw)
To: linux-sparse
Cc: Christopher Li, Mark Rutland, Stephen Boyd, Will Deacon,
Luc Van Oostenryck
By default, sparse only warns on the first overlapping initialier.
While this may be sensible for most situation, it's not always wanted
to hide those others errors. This is especially annoying when testing.
Change this by introducing a new warning flag '-Woverride-init-all',
disabled by default and whose intented use is sparse's testsuite.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 3 ++-
lib.c | 2 ++
lib.h | 1 +
validation/field-override.c | 34 +++++++++++++++++++++++++++++++++-
4 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/expand.c b/expand.c
index 7457c94dd..48cfa33d8 100644
--- a/expand.c
+++ b/expand.c
@@ -925,7 +925,8 @@ static void verify_nonoverlapping(struct expression_list **list)
if (a && bit_offset(a) == bit_offset(b)) {
warning(a->pos, "Initializer entry defined twice");
info(b->pos, " also defined here");
- return;
+ if (!Woverride_init_all)
+ return;
}
a = b;
} END_FOR_EACH_PTR(b);
diff --git a/lib.c b/lib.c
index a20f68aa2..b3b38a43f 100644
--- a/lib.c
+++ b/lib.c
@@ -232,6 +232,7 @@ int Wnon_pointer_null = 1;
int Wold_initializer = 1;
int Wone_bit_signed_bitfield = 1;
int Woverride_init = 1;
+int Woverride_init_all = 0;
int Wparen_string = 0;
int Wptr_subtraction_blows = 0;
int Wreturn_void = 0;
@@ -482,6 +483,7 @@ static const struct warning {
{ "old-initializer", &Wold_initializer },
{ "one-bit-signed-bitfield", &Wone_bit_signed_bitfield },
{ "override-init", &Woverride_init },
+ { "override-init-all", &Woverride_init_all },
{ "paren-string", &Wparen_string },
{ "ptr-subtraction-blows", &Wptr_subtraction_blows },
{ "return-void", &Wreturn_void },
diff --git a/lib.h b/lib.h
index 35edd3217..265c5ec7f 100644
--- a/lib.h
+++ b/lib.h
@@ -118,6 +118,7 @@ extern int Wnon_pointer_null;
extern int Wold_initializer;
extern int Wone_bit_signed_bitfield;
extern int Woverride_init;
+extern int Woverride_init_all;
extern int Wparen_string;
extern int Wptr_subtraction_blows;
extern int Wreturn_void;
diff --git a/validation/field-override.c b/validation/field-override.c
index d5d00dfa8..cae30b4a2 100644
--- a/validation/field-override.c
+++ b/validation/field-override.c
@@ -68,21 +68,53 @@ static struct s b[2] = {
/*
* check-name: field-override
- * check-command: sparse -Woverride-init $file
+ * check-command: sparse -Woverride-init -Woverride-init-all $file
* check-known-to-fail
*
* check-error-start
field-override.c:2:10: warning: Initializer entry defined twice
field-override.c:6:10: also defined here
+field-override.c:3:10: warning: Initializer entry defined twice
+field-override.c:5:10: also defined here
field-override.c:14:10: warning: Initializer entry defined twice
field-override.c:15:10: also defined here
+field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:16:10: also defined here
+field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:17:10: also defined here
+field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:18:10: also defined here
+field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:19:10: also defined here
field-override.c:23:10: warning: Initializer entry defined twice
field-override.c:24:10: also defined here
field-override.c:23:10: warning: Initializer entry defined twice
field-override.c:25:10: also defined here
+field-override.c:23:10: warning: Initializer entry defined twice
+field-override.c:26:10: also defined here
+field-override.c:26:10: warning: Initializer entry defined twice
+field-override.c:27:10: also defined here
+field-override.c:26:10: warning: Initializer entry defined twice
+field-override.c:28:10: also defined here
field-override.c:34:10: warning: Initializer entry defined twice
field-override.c:35:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:36:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:37:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:38:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:39:10: also defined here
+field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:40:10: also defined here
field-override.c:62:10: warning: Initializer entry defined twice
field-override.c:63:10: also defined here
+field-override.c:62:10: warning: Initializer entry defined twice
+field-override.c:65:10: also defined here
+field-override.c:62:10: warning: Initializer entry defined twice
+field-override.c:66:10: also defined here
+field-override.c:62:10: warning: Initializer entry defined twice
+field-override.c:64:10: also defined here
* check-error-end
*/
--
2.11.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] fix checking of overlapping initializer
2017-02-22 15:30 ` [PATCH 0/5] improve detection of overlapping initializers Luc Van Oostenryck
` (2 preceding siblings ...)
2017-02-22 15:30 ` [PATCH 3/5] allow to warn on all " Luc Van Oostenryck
@ 2017-02-22 15:30 ` Luc Van Oostenryck
2017-02-22 15:30 ` [PATCH 5/5] ignore whole-range " Luc Van Oostenryck
4 siblings, 0 replies; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-22 15:30 UTC (permalink / raw)
To: linux-sparse
Cc: Christopher Li, Mark Rutland, Stephen Boyd, Will Deacon,
Luc Van Oostenryck
The current routine checking if some initializers overlap with each
others only check the offset of the initialierd fields, not taking
in account that array elements can be initialized by range with the
'[a ... b]' notation.
Fix this by changing the check so that now we compare the offset of
the current field with the end of the previous one.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 25 +++++++++++++++++++++++--
validation/field-override.c | 1 -
2 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/expand.c b/expand.c
index 48cfa33d8..80699c4d6 100644
--- a/expand.c
+++ b/expand.c
@@ -896,6 +896,20 @@ static unsigned long bit_offset(const struct expression *expr)
return offset;
}
+static unsigned long bit_range(const struct expression *expr)
+{
+ unsigned long range = 0;
+ unsigned long size = 0;
+ while (expr->type == EXPR_POS) {
+ unsigned long nr = expr->init_nr;
+ size = expr->ctype->bit_size;
+ range += (nr - 1) * size;
+ expr = expr->init_expr;
+ }
+ range += size;
+ return range;
+}
+
static int compare_expressions(const void *_a, const void *_b)
{
const struct expression *a = _a;
@@ -914,21 +928,28 @@ static void sort_expression_list(struct expression_list **list)
static void verify_nonoverlapping(struct expression_list **list)
{
struct expression *a = NULL;
+ unsigned long max = 0;
struct expression *b;
if (!Woverride_init)
return;
FOR_EACH_PTR(*list, b) {
+ unsigned long off, end;
if (!b->ctype || !b->ctype->bit_size)
continue;
- if (a && bit_offset(a) == bit_offset(b)) {
+ off = bit_offset(b);
+ if (a && off < max) {
warning(a->pos, "Initializer entry defined twice");
info(b->pos, " also defined here");
if (!Woverride_init_all)
return;
}
- a = b;
+ end = off + bit_range(b);
+ if (end > max) {
+ max = end;
+ a = b;
+ }
} END_FOR_EACH_PTR(b);
}
diff --git a/validation/field-override.c b/validation/field-override.c
index cae30b4a2..5b77af73e 100644
--- a/validation/field-override.c
+++ b/validation/field-override.c
@@ -69,7 +69,6 @@ static struct s b[2] = {
/*
* check-name: field-override
* check-command: sparse -Woverride-init -Woverride-init-all $file
- * check-known-to-fail
*
* check-error-start
field-override.c:2:10: warning: Initializer entry defined twice
--
2.11.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/5] ignore whole-range overlapping initializer
2017-02-22 15:30 ` [PATCH 0/5] improve detection of overlapping initializers Luc Van Oostenryck
` (3 preceding siblings ...)
2017-02-22 15:30 ` [PATCH 4/5] fix checking of overlapping initializer Luc Van Oostenryck
@ 2017-02-22 15:30 ` Luc Van Oostenryck
2017-02-27 16:34 ` Christopher Li
4 siblings, 1 reply; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-22 15:30 UTC (permalink / raw)
To: linux-sparse
Cc: Christopher Li, Mark Rutland, Stephen Boyd, Will Deacon,
Luc Van Oostenryck
When an array is initialized, it may be convenient to first
initialize all entries with some default value via the
'[a ... b]' notation and then override some of these entries
with a non-default value. Unfortunately, this, of course,
is not compatible with the default warning flag '-Woverride-init'.
Fix this by introducing an exception to the usual detection
of overlapping initializers which, only for what concerns this
warning, ignore an '[a ... b]' entry if:
- it is the first one
- it covers the whole range of the array.
If needed, the previous ehaviour can be restored by using a new
warning flag, disabled by default: '-Woverride-init-whole-range'.
Suggested-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 13 +++++++++++--
lib.c | 1 +
lib.h | 1 +
validation/field-override.c | 30 ++++++------------------------
4 files changed, 19 insertions(+), 26 deletions(-)
diff --git a/expand.c b/expand.c
index 80699c4d6..e6928bdc4 100644
--- a/expand.c
+++ b/expand.c
@@ -925,10 +925,11 @@ static void sort_expression_list(struct expression_list **list)
sort_list((struct ptr_list **)list, compare_expressions);
}
-static void verify_nonoverlapping(struct expression_list **list)
+static void verify_nonoverlapping(struct expression_list **list, struct expression *expr)
{
struct expression *a = NULL;
unsigned long max = 0;
+ unsigned long whole = expr->ctype->bit_size;
struct expression *b;
if (!Woverride_init)
@@ -946,6 +947,14 @@ static void verify_nonoverlapping(struct expression_list **list)
return;
}
end = off + bit_range(b);
+ if (!a && !Woverride_init_whole_range) {
+ // If first entry is the whole range, do not let
+ // any warning about it (this allow to initialize
+ // an array with some default value and then override
+ // some specific entries).
+ if (off == 0 && end == whole)
+ continue;
+ }
if (end > max) {
max = end;
a = b;
@@ -1019,7 +1028,7 @@ static int expand_expression(struct expression *expr)
case EXPR_INITIALIZER:
sort_expression_list(&expr->expr_list);
- verify_nonoverlapping(&expr->expr_list);
+ verify_nonoverlapping(&expr->expr_list, expr);
return expand_expression_list(expr->expr_list);
case EXPR_IDENTIFIER:
diff --git a/lib.c b/lib.c
index b3b38a43f..95a4c461d 100644
--- a/lib.c
+++ b/lib.c
@@ -233,6 +233,7 @@ int Wold_initializer = 1;
int Wone_bit_signed_bitfield = 1;
int Woverride_init = 1;
int Woverride_init_all = 0;
+int Woverride_init_whole_range = 0;
int Wparen_string = 0;
int Wptr_subtraction_blows = 0;
int Wreturn_void = 0;
diff --git a/lib.h b/lib.h
index 265c5ec7f..134e56040 100644
--- a/lib.h
+++ b/lib.h
@@ -119,6 +119,7 @@ extern int Wold_initializer;
extern int Wone_bit_signed_bitfield;
extern int Woverride_init;
extern int Woverride_init_all;
+extern int Woverride_init_whole_range;
extern int Wparen_string;
extern int Wptr_subtraction_blows;
extern int Wreturn_void;
diff --git a/validation/field-override.c b/validation/field-override.c
index 5b77af73e..ec6987df7 100644
--- a/validation/field-override.c
+++ b/validation/field-override.c
@@ -75,15 +75,9 @@ field-override.c:2:10: warning: Initializer entry defined twice
field-override.c:6:10: also defined here
field-override.c:3:10: warning: Initializer entry defined twice
field-override.c:5:10: also defined here
-field-override.c:14:10: warning: Initializer entry defined twice
-field-override.c:15:10: also defined here
-field-override.c:14:10: warning: Initializer entry defined twice
-field-override.c:16:10: also defined here
-field-override.c:14:10: warning: Initializer entry defined twice
-field-override.c:17:10: also defined here
-field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:17:10: warning: Initializer entry defined twice
field-override.c:18:10: also defined here
-field-override.c:14:10: warning: Initializer entry defined twice
+field-override.c:17:10: warning: Initializer entry defined twice
field-override.c:19:10: also defined here
field-override.c:23:10: warning: Initializer entry defined twice
field-override.c:24:10: also defined here
@@ -95,25 +89,13 @@ field-override.c:26:10: warning: Initializer entry defined twice
field-override.c:27:10: also defined here
field-override.c:26:10: warning: Initializer entry defined twice
field-override.c:28:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
-field-override.c:35:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:35:10: warning: Initializer entry defined twice
field-override.c:36:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
-field-override.c:37:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:37:10: warning: Initializer entry defined twice
field-override.c:38:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:37:10: warning: Initializer entry defined twice
field-override.c:39:10: also defined here
-field-override.c:34:10: warning: Initializer entry defined twice
+field-override.c:37:10: warning: Initializer entry defined twice
field-override.c:40:10: also defined here
-field-override.c:62:10: warning: Initializer entry defined twice
-field-override.c:63:10: also defined here
-field-override.c:62:10: warning: Initializer entry defined twice
-field-override.c:65:10: also defined here
-field-override.c:62:10: warning: Initializer entry defined twice
-field-override.c:66:10: also defined here
-field-override.c:62:10: warning: Initializer entry defined twice
-field-override.c:64:10: also defined here
* check-error-end
*/
--
2.11.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 5/5] ignore whole-range overlapping initializer
2017-02-22 15:30 ` [PATCH 5/5] ignore whole-range " Luc Van Oostenryck
@ 2017-02-27 16:34 ` Christopher Li
2017-02-27 21:38 ` Luc Van Oostenryck
0 siblings, 1 reply; 11+ messages in thread
From: Christopher Li @ 2017-02-27 16:34 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: Linux-Sparse, Mark Rutland, Stephen Boyd, Will Deacon
On Wed, Feb 22, 2017 at 11:30 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> When an array is initialized, it may be convenient to first
> initialize all entries with some default value via the
> '[a ... b]' notation and then override some of these entries
> with a non-default value. Unfortunately, this, of course,
> is not compatible with the default warning flag '-Woverride-init'.
Looks good to me.
> + if (!a && !Woverride_init_whole_range) {
> + // If first entry is the whole range, do not let
> + // any warning about it (this allow to initialize
> + // an array with some default value and then override
> + // some specific entries).
You might want to use some C style multi line comment /* ... */
Using // for multiple line is a bit strange.
Applied to sparse-next, but if you have update version I will
apply that as well.
Chris
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 5/5] ignore whole-range overlapping initializer
2017-02-27 16:34 ` Christopher Li
@ 2017-02-27 21:38 ` Luc Van Oostenryck
0 siblings, 0 replies; 11+ messages in thread
From: Luc Van Oostenryck @ 2017-02-27 21:38 UTC (permalink / raw)
To: Christopher Li; +Cc: Linux-Sparse, Mark Rutland, Stephen Boyd, Will Deacon
>> + if (!a && !Woverride_init_whole_range) {
>> + // If first entry is the whole range, do not let
>> + // any warning about it (this allow to initialize
>> + // an array with some default value and then override
>> + // some specific entries).
>
> You might want to use some C style multi line comment /* ... */
> Using // for multiple line is a bit strange.
>
> Applied to sparse-next, but if you have update version I will
> apply that as well.
Yes, I tend to always use the C++ style because I'm a lazy typer :)
I'll change it since I've others changes for this serie.
Luc
^ permalink raw reply [flat|nested] 11+ messages in thread